Skip to content

include current runspace and runspace 1 if should #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2019

Conversation

TylerLeonhardt
Copy link
Member

PR Summary

cc @adamdriscoll

This will allow two things:

  • A current option to show up in the Pick PSHostProcess dialog
  • Runspace 1 to show up if the current runspace wasn't chosen

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the comment on the description possibly being improved.

@TylerLeonhardt TylerLeonhardt merged commit 1738ab8 into PowerShell:master Mar 18, 2019
@TylerLeonhardt TylerLeonhardt deleted the include-runspace1 branch March 18, 2019 23:28
TylerLeonhardt added a commit to TylerLeonhardt/vscode-powershell that referenced this pull request Mar 18, 2019
* include current runspace and runspace 1 if should

* to => in

* more explicit
TylerLeonhardt added a commit that referenced this pull request Mar 20, 2019
* include current runspace and runspace 1 if should

* to => in

* more explicit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants