Skip to content

Update recommended NodeJS version to 8.x since 6.x will go out of support in April 2019 and is already in maintenance mode #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2018

Conversation

bergmeister
Copy link
Contributor

@bergmeister bergmeister commented Dec 21, 2018

PR Summary

As per title, for more details see here. 6.x is not active any more and only in maintenance mode, therefore bump the minimum to 8.x, which will be supported at least until December 31, 2019.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister bergmeister changed the title Update recommended NodeJS version to 8.x since 6.x will go out of support in April 2019 Update recommended NodeJS version to 8.x since 6.x will go out of support in April 2019 and is already in maintenance mode Dec 21, 2018
Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TylerLeonhardt TylerLeonhardt merged commit b9ca115 into PowerShell:master Dec 22, 2018
@TylerLeonhardt
Copy link
Member

Thanks for all your help on our dependencies, @bergmeister!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants