-
Notifications
You must be signed in to change notification settings - Fork 511
Add icons for Command Explorer #1638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons for Command Explorer #1638
Conversation
Change refrech icon to use octicons (https://octicons.github.com)
Reword Refresh to specify what it's Refreshing. Remove Insert from Command Palette.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the setting just needs a quick name check but LGTM otherwise.
From my investigation, if you navigate to View > Appearance there's two options. There's |
Given this info. Ignore all my comments. :) |
Be consistent with UI
@@ -456,6 +477,11 @@ | |||
"type": "object", | |||
"title": "PowerShell Configuration", | |||
"properties": { | |||
"powershell.sideBar.CommandExplorerVisibility": { | |||
"type": "boolean", | |||
"default":true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should've been a space after the colon (:
). I opened PR #1688 to fix it. Running Invoke-Build
at the end helps with that.
Change refrech icon to use octicons (https://octicons.github.com)
PR Summary
Add some icons for usability.
Add configuration to toggle visibility of Command Explorer
Needing to right click isn't super intuitive.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets.Please mark anything not applicable to this PR
NA
.WIP:
to the beginning of the title and remove the prefix when the PR is ready