From aeff3f0e91cf849f5602822e327a392e4d245c2c Mon Sep 17 00:00:00 2001 From: "Christoph Bergmeister [MVP]" Date: Thu, 3 Oct 2019 00:23:16 +0100 Subject: [PATCH 1/3] Fix PipelineIndentation configuration issue (#1050) --- .../Server/LanguageServerSettings.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PowerShellEditorServices.Protocol/Server/LanguageServerSettings.cs b/src/PowerShellEditorServices.Protocol/Server/LanguageServerSettings.cs index 6106fb25c..2c1d0b7df 100644 --- a/src/PowerShellEditorServices.Protocol/Server/LanguageServerSettings.cs +++ b/src/PowerShellEditorServices.Protocol/Server/LanguageServerSettings.cs @@ -264,6 +264,7 @@ private Hashtable GetCustomPSSASettingsHashtable(int tabSize, bool insertSpaces) {"PSUseConsistentIndentation", new Hashtable { {"Enable", true}, {"IndentationSize", tabSize}, + {"PipelineIndentation", PipelineIndentationStyle }, {"Kind", insertSpaces ? "space" : "tab"} }}, {"PSUseConsistentWhitespace", new Hashtable { From 74320f7c2242f3f565602fa7e54d1bb7d712197d Mon Sep 17 00:00:00 2001 From: "Christoph Bergmeister [MVP]" Date: Thu, 3 Oct 2019 21:00:17 +0100 Subject: [PATCH 2/3] legacy/1.x: Update minimum PSSA version to 1.18.3 (#1052) --- modules.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules.json b/modules.json index 8777ca207..df8ff6935 100644 --- a/modules.json +++ b/modules.json @@ -1,6 +1,6 @@ { "PSScriptAnalyzer":{ - "MinimumVersion":"1.18.2", + "MinimumVersion":"1.18.3", "MaximumVersion":"1.99", "AllowPrerelease":false }, From 7b4aa460682d88debb43dd55726071e60b5e5ffd Mon Sep 17 00:00:00 2001 From: Christoph Bergmeister Date: Wed, 13 Nov 2019 09:38:51 +0000 Subject: [PATCH 3/3] Backport of #1101: Add PSAvoidAssignmentToAutomaticVariable to the default set of PSSA rules --- src/PowerShellEditorServices/Analysis/AnalysisService.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PowerShellEditorServices/Analysis/AnalysisService.cs b/src/PowerShellEditorServices/Analysis/AnalysisService.cs index e7badac84..69489a09d 100644 --- a/src/PowerShellEditorServices/Analysis/AnalysisService.cs +++ b/src/PowerShellEditorServices/Analysis/AnalysisService.cs @@ -31,6 +31,7 @@ public class AnalysisService : IDisposable /// no settings file is specified. /// private static readonly string[] s_includedRules = { + "PSAvoidAssignmentToAutomaticVariable", "PSUseToExportFieldsInManifest", "PSMisleadingBacktick", "PSAvoidUsingCmdletAliases",