Skip to content

Tests needed for ReadKeyAsync changes #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SeeminglyScience opened this issue Jan 6, 2018 · 3 comments
Closed

Tests needed for ReadKeyAsync changes #604

SeeminglyScience opened this issue Jan 6, 2018 · 3 comments

Comments

@SeeminglyScience
Copy link
Collaborator

Opening this issue as a reminder that tests need to be created for the changes to our internal ReadKeyAsync method. From PR #592

@TylerLeonhardt
Copy link
Member

:) thanks!

@WernerMairl
Copy link

hi
i'm one of the issuer, now ready for a retest on Ubuntu...
where i can download/install the latest master build (assuming that the fix is merged) ?

i have found the following:

https://travis-ci.org/PowerShell/vscode-powershell/builds/333064180
but not able to find/download build output artifacts....

regards
Werner

@SeeminglyScience
Copy link
Collaborator Author

SeeminglyScience commented Jan 27, 2018

@WernerMairl this issue is about writing automated tests, but we'd love for you to try it out as well :)

  1. Grab the build from AppVeyor here. Note that this archive was built on Windows, some compression utilities won't automatically translate the Windows directory separators to Linux. Ubuntu should though.

  2. In the integrated console, type ii ((gmo PowerShellEditorServices.Commands).ModuleBase|Split-Path). That should open the PSES folder within the extension in your file explorer.

  3. Make sure all instances of VSCode are closed

  4. Copy the contents of the PowerShellEditorServices folder from the zip into the window opened in step 2

  5. If you get access denied errors, try running gps pwsh|? id -ne $pid|spps in a separate PowerShell window

Note: The changes in their current state could prevent the CPU from entering low power mode if you leave VSCode open. That'll be fixed before this releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants