Add support for breakpoint hit count

[rkeithhill]

Just saw this in the 1.7 insider's release notes. Sounds like debugger extensions must be modified to support this. I suspect this should be easy to support.

[daviwil]

Sounds good! That will be a nice addition.

[rkeithhill]

Investigated and ran into a snag. Enh request for PowerShell here: PowerShell/PowerShell#2594

Initial work is committed to my fork: rkeithhill@f56a683

Might be able to track the conditional break count ourselves and get this done. Need to think on it some.

[daviwil]

Even if this improves in PowerShell 6.0+, we'd still have to make it work for older versions. I think we'll have to do it ourselves for now. Maybe we can augment the user's condition code if it helps?

[rkeithhill]

True enough. I'll experiment with maintaining the hit count in a global variable. Do we have a naming convention for globals created by the debugger? Maybe something like __psEditorServices_hitCount?

[rkeithhill]

OK, this seems to work although it does inject a global into the debug session. I think that should be OK.

if (<user expression>) { if (++$global:__psEditorServices_BreakHitCounter_1 -eq <user hit count>) { break } }

Note that I maintain a static "breakpointHitCounter" that gets incremented each time a breakpoint like this is set. So the next hit count breakpoint would look like this:

if (<user expression>) { if (++$global:__psEditorServices_BreakHitCounter_2 -eq <user hit count>) { break } }

Where the global variable has a different name $global:__psEditorServices_BreakHitCounter_2 than the previous global variable.

Not done with this yet. If there is no "condition" then we won't need to create a global. We can use the breakpoint's HitCount property e.g.:

if ($_.HitCount -eq <user hit count>) {  break  }

I hope to check this in by Saturday.

[daviwil]

This is done right? Should we close it?

[rkeithhill]

Yes, it has been implemented.