Skip to content

Simplify PSES CLI so startup with non-Code editors is easier #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andyleejordan opened this issue Jul 13, 2022 · 3 comments · Fixed by #2129
Closed

Simplify PSES CLI so startup with non-Code editors is easier #1855

andyleejordan opened this issue Jul 13, 2022 · 3 comments · Fixed by #2129
Assignees
Labels
Area-Startup Issue-Enhancement A feature request (enhancement).

Comments

@andyleejordan
Copy link
Member

andyleejordan commented Jul 13, 2022

It takes way too many arguments to launch PSES correctly, which is blocking #1829. Once we simplify this, we could conceivably add a -lsp flag to PowerShell itself that would simplify it even further.

@ghost ghost added the Needs: Triage Maintainer attention needed! label Jul 13, 2022
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Startup and removed Needs: Triage Maintainer attention needed! labels Jul 13, 2022
@andyleejordan andyleejordan self-assigned this Jul 13, 2022
@andyleejordan andyleejordan moved this from Todo to Missed in American Pharoah Oct 4, 2022
@pinuke
Copy link
Contributor

pinuke commented Oct 18, 2022

How definitive is this? Do you intend to completely rewrite the CLI/introduce "breaking changes" with this? I imagine that any changes you would make would have to be backwards compatible.

But I have to ask, since my PSES manual controller is dependent on how your CLI works.

@andyleejordan
Copy link
Member Author

I don't intend to make breaking changes. The best coverage I have for that is

`(powershell-mode
. ("pwsh" "-NoLogo" "-NoProfile" "-Command" ,start-script
"-HostName" "Emacs" "-HostProfileId" "Emacs" "-HostVersion" "1.0.0"
"-BundledModulesPath" ,module-path
"-LogPath" ,log-path "-LogLevel" "Diagnostic"
"-SessionDetailsPath" ,session-path
"-Stdio")))

and

let g:LanguageClient_serverCommands = {
\ 'ps1': ['pwsh', '-NoLogo', '-NoProfile', '-Command',
\ l:pses_path . '/PowerShellEditorServices/Start-EditorServices.ps1',
\ '-HostName', 'vim', '-HostProfileId', 'vim', '-HostVersion', '1.0.0',
\ '-BundledModulesPath', l:pses_path, '-Stdio',
\ '-LogPath', g:repo_root . '/pses.log', '-LogLevel', 'Diagnostic',
\ '-SessionDetailsPath', g:repo_root . '/pses_session.json' ]
\ }

@fai8146767
Copy link

****

@andyleejordan andyleejordan moved this from Todo to In Progress in Flying Fox Jan 12, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Flying Fox Feb 29, 2024
@github-project-automation github-project-automation bot moved this from Punted to Done in American Pharoah Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Startup Issue-Enhancement A feature request (enhancement).
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants