Skip to content

Extension won't start with invalid (empty string) powershell.cwd #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
andyleejordan opened this issue Jul 5, 2022 · 0 comments · Fixed by #1851
Closed
3 tasks done

Extension won't start with invalid (empty string) powershell.cwd #1849

andyleejordan opened this issue Jul 5, 2022 · 0 comments · Fixed by #1851
Assignees
@andyleejordan
Labels
Area-Startup Issue-Bug A bug to squash.

Comments

@andyleejordan
Copy link
Member

andyleejordan commented Jul 5, 2022 •
edited
Loading

Prerequisites

  • Write a descriptive title.
  • Make sure you are able to repro it on the latest version
  • Search the existing issues.

Steps to reproduce

Per PowerShell/vscode-powershell#4059 (comment), setting and then unsetting the cwd setting will result in an empty string, which the client is fine with, but causes the server to fail to start.

Expected behavior

Server starts with any setting for `powershell.cwd`.

Actual behavior

Server hangs.

Error details

No response

Environment data

N/A

Version

v2022.6.3

Visuals

No response
@ghost ghost added the Needs: Triage Maintainer attention needed! label Jul 5, 2022
@andyleejordan andyleejordan self-assigned this Jul 5, 2022
@andyleejordan andyleejordan added Issue-Bug A bug to squash. Area-Startup and removed Needs: Triage Maintainer attention needed! labels Jul 5, 2022
@andyleejordan andyleejordan mentioned this issue Jul 5, 2022
Merged
@andyleejordan andyleejordan moved this to In Progress in American Pharoah Jul 5, 2022
Repository owner moved this from In Progress to Done in American Pharoah Jul 6, 2022
@andyleejordan andyleejordan mentioned this issue Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyleejordan andyleejordan

Labels
Area-Startup Issue-Bug A bug to squash.
Projects
No open projects
American Pharoah
Status: Done
Milestone
No milestone
1 participant
@andyleejordan