Skip to content

Cancel Keystroke should not end a debugging session in the pipeline #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JustinGrote opened this issue Feb 15, 2022 · 6 comments · Fixed by #1712
Closed

Cancel Keystroke should not end a debugging session in the pipeline #1708

JustinGrote opened this issue Feb 15, 2022 · 6 comments · Fixed by #1712
Assignees
Labels
Area-Engine Issue-Bug A bug to squash.

Comments

@JustinGrote
Copy link
Collaborator

To reproduce:

Hit F5 to start debug
Wait-Debugger
Hit ctrl-c, note that it doesnt end the PSES session
sleep 5
Hit ctrl-c, note that the PSES debug session dies
@ghost ghost added the Needs: Triage Maintainer attention needed! label Feb 15, 2022
@JustinGrote JustinGrote added Area-Engine Issue-Bug A bug to squash. and removed Needs: Triage Maintainer attention needed! labels Feb 15, 2022
@andyleejordan
Copy link
Member

I'm going to drop a new preview, let's see if this still repros.

@andyleejordan
Copy link
Member

Wait, yes it should: PowerShell/vscode-powershell#3700

@andyleejordan
Copy link
Member

Yeah this is working as intended. We wired up OnCancelKeyPress to stop the debugger here: 0f52aa2

@JustinGrote
Copy link
Collaborator Author

JustinGrote commented Feb 16, 2022

@andschwa confirmed working fine in new preview, thanks! I did notice ctrl-c with sleep 5 will end the debug session if running a "naked" psinteractive session, reopening to confirm if that's what we want or if we want to fix that too.

To repro:
Launch config

			{
				"name": "PS: Interactive",
				"presentation": {
					"group": "Powershell"
				},
				"request": "launch",
				"type": "PowerShell"
			},

sleep 5 and hit ctrl-c, it will end the session.

Capture.mp4

@andyleejordan
Copy link
Member

That makes sense, I don't see anyway we'd be able to differentiate debugged tasks in an PS Interactive session. Technically they're all under the debugger.

@andyleejordan
Copy link
Member

The fix for this is out in PowerShell Preview!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Engine Issue-Bug A bug to squash.
Projects
None yet
2 participants