Skip to content

Revert language version fix and find another fix? #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andyleejordan opened this issue Aug 16, 2021 · 4 comments · Fixed by #1546
Closed

Revert language version fix and find another fix? #1544

andyleejordan opened this issue Aug 16, 2021 · 4 comments · Fixed by #1546
Labels
Area-Build & Release Issue-Enhancement A feature request (enhancement).

Comments

@andyleejordan
Copy link
Member

In #1541 we updated the language version from 9.0 to 10.0 to workaround a bug with .NET 6 Preview 7; however, this isn't the greatest workaround because it requires everyone building PSES to update their dotnet:

CSC : error CS1617: Invalid option '10.0' for /langversion. Use '/langversion:?' to list supported values. [/Users/andschwa/src/PowerShellEditorServices/src/PowerShellEditorServices/PowerShellEditorServices.csproj]

We didn't realize this because the CI always comes with an up-to-date dotnet.

The simply solution is for PSES devs to just delete .dotnet and let the build script install the latest, but perhaps we should fix it another way.

@ghost ghost added the Needs: Triage Maintainer attention needed! label Aug 16, 2021
@andyleejordan
Copy link
Member Author

Sorry @rjmholt.

@rjmholt
Copy link
Contributor

rjmholt commented Aug 16, 2021

I'm guessing setting LangVersion to latest isn't going to work for some target frameworks...

@andyleejordan
Copy link
Member Author

Probably not, and I don't particularly want to just randomly adopt their newest language 😢

@rjmholt
Copy link
Contributor

rjmholt commented Aug 16, 2021

just randomly adopt their newest language

It tends to be tethered to the framework version, but yeah it's probably not the right solution here.

Maybe we want a conditional entry to temporarily work around the issue? Not sure if there's an easy way to test the sdk version

@andyleejordan andyleejordan added Area-Build & Release Issue-Enhancement A feature request (enhancement). and removed Needs: Triage Maintainer attention needed! labels Aug 18, 2021
@ghost ghost added the Status: In PR label Aug 18, 2021
@ghost ghost added Status: Fixed and removed Status: In PR labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build & Release Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants