Skip to content

Re-enable Console/ChoicePromptHandlerTests.cs #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andyleejordan opened this issue Mar 29, 2021 · 1 comment · Fixed by #1660
Closed

Re-enable Console/ChoicePromptHandlerTests.cs #1440

andyleejordan opened this issue Mar 29, 2021 · 1 comment · Fixed by #1660
Assignees
@andyleejordan
Labels
Area-Test Issue-Bug A bug to squash.

Comments

@andyleejordan
Copy link
Member

andyleejordan commented Mar 29, 2021 •
edited
Loading

Two of this file's three tests are skipped:

PowerShellEditorServices/test/PowerShellEditorServices.Test/Console/ChoicePromptHandlerTests.cs

Lines 27 to 28 in d54bda7

[Fact(Skip = "This test fails often and is not designed well...")]
public void ChoicePromptReturnsCorrectIdForChoice()

PowerShellEditorServices/test/PowerShellEditorServices.Test/Console/ChoicePromptHandlerTests.cs

Lines 50 to 51 in d54bda7

[Fact(Skip = "Hotkeys are not exposed while VSCode ignores them")]
public void ChoicePromptReturnsCorrectIdForHotKey()

@andyleejordan andyleejordan self-assigned this Mar 29, 2021
@andyleejordan andyleejordan changed the title Fix skipped tests in Console/ChoicePromptHandlerTests.cs Fix skipped tests in ChoicePromptHandlerTests.cs Mar 29, 2021
@andyleejordan andyleejordan changed the title Fix skipped tests in ChoicePromptHandlerTests.cs Fix skipped tests in Console/ChoicePromptHandlerTests.cs Mar 29, 2021
@andyleejordan andyleejordan removed their assignment Mar 29, 2021
@andyleejordan andyleejordan changed the title Fix skipped tests in Console/ChoicePromptHandlerTests.cs Re-enable Console/ChoicePromptHandlerTests.cs Jan 5, 2022
@andyleejordan andyleejordan self-assigned this Jan 5, 2022
@andyleejordan andyleejordan added the Issue-Bug A bug to squash. label Jan 5, 2022
@andyleejordan
Copy link
Member Author

These are actually now all disabled.

@andyleejordan andyleejordan mentioned this issue Jan 11, 2022
Merged
@ghost ghost added the Status: In PR label Jan 11, 2022
@ghost ghost added Status: Fixed and removed Status: In PR labels Jan 11, 2022
@andyleejordan andyleejordan moved this to Todo in Sea Biscuit Jan 24, 2022
@andyleejordan andyleejordan moved this from Todo to Done in Sea Biscuit Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyleejordan andyleejordan

Labels
Area-Test Issue-Bug A bug to squash.
Projects
No open projects
Sea Biscuit
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete ChoicePromptHandlerTests and InputPromptHandlerTests PowerShell/PowerShellEditorServices
1 participant
@andyleejordan