Remove DebugStateService.OwnsEditorSession

Since the pipeline rewrite, it is no longer necessary for the
`ConfigurationDoneHandler` to manually start the debug loop when
temporary consoles are created for debug sessions. Because of this, we
can stop plumbing this information all the way through from the top.

Author: andyleejordan

src/PowerShellEditorServices/Hosting/EditorServicesServerFactory.cs

@@ -119,7 +119,6 @@ public PsesDebugServer CreateDebugServerWithLanguageServer(
                 inputStream,
                 outputStream,
                 languageServer.LanguageServer.Services,
-                useTempSession: false,
                 usePSReadLine);
         }
 
@@ -144,7 +143,6 @@ public PsesDebugServer RecreateDebugServer(
                 inputStream,
                 outputStream,
                 debugServer.ServiceProvider,
-                useTempSession: false,
                 usePSReadLine);
         }
 
@@ -184,7 +182,6 @@ public PsesDebugServer CreateDebugServerForTempSession(
                 inputStream,
                 outputStream,
                 serviceProvider,
-                useTempSession: true,
                 usePSReadLine: hostStartupInfo.ConsoleReplEnabled && !hostStartupInfo.UsesLegacyReadLine);
         }
 

src/PowerShellEditorServices/Server/PsesDebugServer.cs

@@ -23,7 +23,6 @@ internal class PsesDebugServer : IDisposable
     {
         private readonly Stream _inputStream;
         private readonly Stream _outputStream;
-        private readonly bool _useTempSession;
         private readonly bool _usePSReadLine;
         private readonly TaskCompletionSource<bool> _serverStopped;
 
@@ -40,14 +39,12 @@ public PsesDebugServer(
             Stream inputStream,
             Stream outputStream,
             IServiceProvider serviceProvider,
-            bool useTempSession,
             bool usePSReadLine)
         {
             _loggerFactory = factory;
             _inputStream = inputStream;
             _outputStream = outputStream;
             ServiceProvider = serviceProvider;
-            _useTempSession = useTempSession;
             _serverStopped = new TaskCompletionSource<bool>();
             _usePSReadLine = usePSReadLine;
         }
@@ -74,7 +71,7 @@ public async Task StartAsync()
                         serviceCollection
                             .AddLogging()
                             .AddOptions()
-                            .AddPsesDebugServices(ServiceProvider, this, _useTempSession))
+                            .AddPsesDebugServices(ServiceProvider, this))
                     // TODO: Consider replacing all WithHandler with AddSingleton
                     .WithHandler<LaunchAndAttachHandler>()
                     .WithHandler<DisconnectHandler>()

src/PowerShellEditorServices/Server/PsesServiceCollectionExtensions.cs

@@ -59,8 +59,7 @@ public static IServiceCollection AddPsesLanguageServices(
         public static IServiceCollection AddPsesDebugServices(
             this IServiceCollection collection,
             IServiceProvider languageServiceProvider,
-            PsesDebugServer psesDebugServer,
-            bool useTempSession)
+            PsesDebugServer psesDebugServer)
         {
             PsesInternalHost internalHost = languageServiceProvider.GetService<PsesInternalHost>();
 
@@ -74,10 +73,7 @@ public static IServiceCollection AddPsesDebugServices(
                 .AddSingleton<PsesDebugServer>(psesDebugServer)
                 .AddSingleton<DebugService>()
                 .AddSingleton<BreakpointService>()
-                .AddSingleton<DebugStateService>(new DebugStateService
-                {
-                     OwnsEditorSession = useTempSession
-                })
+                .AddSingleton<DebugStateService>()
                 .AddSingleton<DebugEventHandlerService>();
         }
     }

src/PowerShellEditorServices/Services/DebugAdapter/DebugStateService.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using System.Threading;
@@ -25,8 +25,6 @@ internal class DebugStateService
 
         internal string ScriptToLaunch { get; set; }
 
-        internal bool OwnsEditorSession { get; set; }
-
         internal bool ExecutionCompleted { get; set; }
 
         internal bool IsInteractiveDebugSession { get; set; }

src/PowerShellEditorServices/Services/DebugAdapter/Handlers/ConfigurationDoneHandler.cs

@@ -68,13 +68,6 @@ public Task<ConfigurationDoneResponse> Handle(ConfigurationDoneArguments request
         {
             _debugService.IsClientAttached = true;
 
-            if (_debugStateService.OwnsEditorSession)
-            {
-                // TODO: If this is a debug-only session, we need to start the command loop manually
-                //
-                //_powerShellContextService.ConsoleReader.StartCommandLoop();
-            }
-
             if (!string.IsNullOrEmpty(_debugStateService.ScriptToLaunch))
             {
                 // NOTE: This is an unawaited task because responding to "configuration done" means