Use a minimal set of Script Analyzer rules

This change greatly reduces the set of Script Analyzer rules that are used
by default in the analysis service.  In the future, this list of rules
will be fully configurable by the user.  This change is meant to simplify
the ruleset in the meantime.

Author: daviwil

src/PowerShellEditorServices/Analysis/AnalysisService.cs

@@ -23,6 +23,22 @@ public class AnalysisService : IDisposable
         private Runspace analysisRunspace;
         private ScriptAnalyzer scriptAnalyzer;
 
+        /// <summary>
+        /// Defines the list of Script Analyzer rules to include by default.
+        /// In the future, a default rule set from Script Analyzer may be used.
+        /// </summary>
+        private static readonly string[] IncludedRules = new string[]
+        {
+            "PSUseApprovedVerbs",
+            "PSReservedCmdletChar",
+            "PSReservedParams",
+            "PSShouldProcess",
+            "PSUseShouldProcessForStateChangingFunctions",
+            "PSUseSingularNouns",
+            "PSMissingModuleManifestField",
+            "PSAvoidDefaultValueSwitchParameter"
+        };
+
         #endregion
 
         #region Constructors
@@ -32,8 +48,6 @@ public class AnalysisService : IDisposable
         /// </summary>
         public AnalysisService()
         {
-            // TODO: Share runspace with PowerShellContext?  Probably should always
-            //       run analysis in a local session.
             this.analysisRunspace = RunspaceFactory.CreateRunspace(InitialSessionState.CreateDefault2());
             this.analysisRunspace.ApartmentState = ApartmentState.STA;
             this.analysisRunspace.ThreadOptions = PSThreadOptions.ReuseThread;
@@ -44,8 +58,7 @@ public AnalysisService()
                 this.analysisRunspace,
                 new AnalysisOutputWriter(),
                 null,
-                null,
-                new string[] { "DscTestsPresent", "DscExamplesPresent" });
+                IncludedRules);
         }
 
         #endregion