Remove while loop used for reading error stream

Whenever EditorServices fails to start up, ServerTestsBase.LaunchService goes into a while loop where it reads from the error stream line by line in an async manner, till the end of the stream. This causes the method to wait indefinitely in certain situations. Hence, we replace it with ReadToEndAsync method and time out on the task if it takes too long. This avoids the test cases from hanging at that point.

Author: Kapil Borle

test/PowerShellEditorServices.Test.Host/ServerTestsBase.cs

@@ -102,19 +102,16 @@ protected async Task<Tuple<int, int>> LaunchService(
             {
                 // Must have read an error?  Keep reading from error stream
                 string errorString = completedRead.Result;
+                Task<string> errorRead = this.serviceProcess.StandardError.ReadToEndAsync();
 
-                while (true)
+                // Lets give the read operation 5 seconds to complete. Ideally, it shouldn't
+                // take that long at all, but just in case...
+                if (errorRead.Wait(5000))
                 {
-                    Task<string> errorRead = this.serviceProcess.StandardError.ReadLineAsync();
-
                     if (!string.IsNullOrEmpty(errorRead.Result))
                     {
                         errorString += errorRead.Result + Environment.NewLine;
                     }
-                    else
-                    {
-                        break;
-                    }
                 }
 
                 throw new Exception("Could not launch powershell.exe:\r\n\r\n" + errorString);