Skip to content

Commit ecca1de

Browse files
committed
Skip HoverRequest on Windows for Now
1 parent c8f1c3e commit ecca1de

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1095,7 +1095,8 @@ await PsesLanguageClient
10951095
[SkippableFact]
10961096
public async Task CanSendHoverRequestAsync()
10971097
{
1098-
Skip.If(PsesStdioLanguageServerProcessHost.IsWindowsPowerShell, "TODO: Fix this in hover refactor");
1098+
Skip.If(Environment.OSVersion.Platform == PlatformID.Win32NT,
1099+
"TODO: Fails in Windows GHA but works locally for some reason.");
10991100
string filePath = NewTestFile("Write-Host");
11001101

11011102
Hover hover = await PsesLanguageClient.TextDocument.RequestHover(

test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs

+2-5
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using System.Collections.Generic;
55
using System.Linq;
66
using System.Management.Automation;
7-
using System.Runtime.InteropServices;
87
using System.Threading;
98
using System.Threading.Tasks;
109
using Microsoft.Extensions.Logging.Abstractions;
@@ -33,7 +32,6 @@ public class SymbolsServiceTests : IAsyncLifetime
3332
private PsesInternalHost psesHost;
3433
private WorkspaceService workspace;
3534
private SymbolsService symbolsService;
36-
private static readonly bool s_isWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
3735

3836
public async Task InitializeAsync()
3937
{
@@ -755,7 +753,6 @@ public async Task FindsReferencesOnEnumMember()
755753
Assert.Equal(symbols, GetOccurrences(FindsOccurrencesOnTypeSymbolsData.EnumMemberSourceDetails));
756754
}
757755

758-
// This test fetches every command in PS,
759756
[Fact]
760757
public async Task FindsDetailsForBuiltInCommand()
761758
{
@@ -902,10 +899,10 @@ public void FindsSymbolsWithNewLineInFile()
902899
AssertIsRegion(symbol.ScriptRegion, 27, 5, 27, 10);
903900
}
904901

905-
[Fact(Skip = "DSC symbols don't work yet.")]
902+
[SkippableFact()]
906903
public void FindsSymbolsInDSCFile()
907904
{
908-
Skip.If(!s_isWindows, "DSC only works properly on Windows.");
905+
// Skip.If(!s_isWindows, "DSC only works properly on Windows.");
909906

910907
IEnumerable<SymbolReference> symbols = FindSymbolsInFile(FindSymbolsInDSCFile.SourceDetails);
911908
SymbolReference symbol = Assert.Single(symbols, i => i.Type == SymbolType.Configuration);

0 commit comments

Comments
 (0)