Skip to content

Commit e72a796

Browse files
committed
Resurrect FindsReferencesOnFunction and FindsReferencesOnVariable tests
This had been erroneously removed in commit 32451c0 leading to dead code, but were able to be resurrected without issue.
1 parent 4261327 commit e72a796

File tree

3 files changed

+38
-23
lines changed

3 files changed

+38
-23
lines changed

test/PowerShellEditorServices.Test.Shared/References/FindsReferencesOnFunction.cs

+10-12
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,16 @@
55

66
namespace Microsoft.PowerShell.EditorServices.Test.Shared.References
77
{
8-
public class FindsReferencesOnFunction
8+
public static class FindsReferencesOnFunctionData
99
{
10-
public static readonly ScriptRegion SourceDetails =
11-
new ScriptRegion(
12-
file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
13-
text: string.Empty,
14-
startLineNumber: 3,
15-
startColumnNumber: 8,
16-
startOffset: 0,
17-
endLineNumber: 0,
18-
endColumnNumber: 0,
19-
endOffset: 0);
10+
public static readonly ScriptRegion SourceDetails = new(
11+
file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
12+
text: string.Empty,
13+
startLineNumber: 3,
14+
startColumnNumber: 8,
15+
startOffset: 0,
16+
endLineNumber: 0,
17+
endColumnNumber: 0,
18+
endOffset: 0);
2019
}
2120
}
22-

test/PowerShellEditorServices.Test.Shared/References/FindsReferencesonVariable.cs

+10-11
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,16 @@
55

66
namespace Microsoft.PowerShell.EditorServices.Test.Shared.References
77
{
8-
public class FindsReferencesOnVariable
8+
public static class FindsReferencesOnVariableData
99
{
10-
public static readonly ScriptRegion SourceDetails =
11-
new ScriptRegion(
12-
file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
13-
text: string.Empty,
14-
startLineNumber: 10,
15-
startColumnNumber: 17,
16-
startOffset: 0,
17-
endLineNumber: 0,
18-
endColumnNumber: 0,
19-
endOffset: 0);
10+
public static readonly ScriptRegion SourceDetails = new(
11+
file: TestUtilities.NormalizePath("References/SimpleFile.ps1"),
12+
text: string.Empty,
13+
startLineNumber: 10,
14+
startColumnNumber: 17,
15+
startOffset: 0,
16+
endLineNumber: 0,
17+
endColumnNumber: 0,
18+
endOffset: 0);
2019
}
2120
}

test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs

+18
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,15 @@ public async Task FindsFunctionDefinition()
125125
Assert.Equal("My-Function", definitionResult.SymbolName);
126126
}
127127

128+
[Fact]
129+
public void FindsReferencesOnFunction()
130+
{
131+
List<SymbolReference> referencesResult = GetReferences(FindsReferencesOnFunctionData.SourceDetails);
132+
Assert.Equal(3, referencesResult.Count);
133+
Assert.Equal(1, referencesResult[0].ScriptRegion.StartLineNumber);
134+
Assert.Equal(10, referencesResult[0].ScriptRegion.StartColumnNumber);
135+
}
136+
128137
[Fact]
129138
public async Task FindsFunctionDefinitionInDotSourceReference()
130139
{
@@ -167,6 +176,15 @@ public async Task FindsVariableDefinition()
167176
Assert.Equal("$things", definitionResult.SymbolName);
168177
}
169178

179+
[Fact]
180+
public void FindsReferencesOnVariable()
181+
{
182+
List<SymbolReference> referencesResult = GetReferences(FindsReferencesOnVariableData.SourceDetails);
183+
Assert.Equal(3, referencesResult.Count);
184+
Assert.Equal(10, referencesResult[referencesResult.Count - 1].ScriptRegion.StartLineNumber);
185+
Assert.Equal(13, referencesResult[referencesResult.Count - 1].ScriptRegion.StartColumnNumber);
186+
}
187+
170188
[Fact]
171189
public void FindsOccurrencesOnFunction()
172190
{

0 commit comments

Comments
 (0)