Removed new parameter and switched instead on whether Stdio is in use determine whether or not to use the NullPSHostUI

Author: andyleejordan

src/PowerShellEditorServices.Hosting/Commands/StartEditorServicesCommand.cs

@@ -351,6 +351,7 @@ private EditorServicesConfig CreateConfigObject()
                 FeatureFlags = FeatureFlags,
                 LogLevel = LogLevel,
                 ConsoleRepl = GetReplKind(),
+                UseNullPSHostUI = Stdio,
                 AdditionalModules = AdditionalModules,
                 LanguageServiceTransport = GetLanguageServiceTransport(),
                 DebugServiceTransport = GetDebugServiceTransport(),

src/PowerShellEditorServices.Hosting/Configuration/EditorServicesConfig.cs

@@ -89,6 +89,11 @@ public EditorServicesConfig(
         /// </summary>
         public ConsoleReplKind ConsoleRepl { get; set; } = ConsoleReplKind.None;
 
+        /// <summary>
+        /// Will suppress messages to PSHost (to prevent Stdio clobbering)        
+        /// </summary>
+        public bool UseNullPSHostUI { get; set; }
+
         /// <summary>
         /// The minimum log level to log events with.
         /// </summary>

src/PowerShellEditorServices.Hosting/Internal/EditorServicesRunner.cs

@@ -1,11 +1,11 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
+using Microsoft.PowerShell.EditorServices.Server;
 using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Threading.Tasks;
-using Microsoft.PowerShell.EditorServices.Server;
 
 namespace Microsoft.PowerShell.EditorServices.Hosting
 {
@@ -289,6 +289,7 @@ private HostStartupInfo CreateHostStartupInfo()
                 _config.LogPath,
                 (int)_config.LogLevel,
                 consoleReplEnabled: _config.ConsoleRepl != ConsoleReplKind.None,
+                useNullPSHostUI: _config.UseNullPSHostUI,
                 usesLegacyReadLine: _config.ConsoleRepl == ConsoleReplKind.LegacyReadLine,
                 bundledModulePath: _config.BundledModulePath);
         }

src/PowerShellEditorServices/Hosting/HostStartupInfo.cs

@@ -76,6 +76,11 @@ public sealed class HostStartupInfo
         /// </summary>
         public bool ConsoleReplEnabled { get; }
 
+        /// <summary>
+        /// True if we want to suppress messages to PSHost (to prevent Stdio clobbering)
+        /// </summary>
+        public bool UseNullPSHostUI { get; }
+
         /// <summary>
         /// If true, the legacy PSES readline implementation will be used. Otherwise PSReadLine will be used.
         /// If the console REPL is not enabled, this setting will be ignored.
@@ -154,7 +159,8 @@ public HostStartupInfo(
             int logLevel,
             bool consoleReplEnabled,
             bool usesLegacyReadLine,
-            string bundledModulePath)
+            string bundledModulePath,
+            bool useNullPSHostUI)
         {
             Name = name ?? DefaultHostName;
             ProfileId = profileId ?? DefaultHostProfileId;
@@ -177,6 +183,7 @@ public HostStartupInfo(
                     "..",
                     "..",
                     ".."));
+            UseNullPSHostUI = useNullPSHostUI;
         }
 
         #endregion

src/PowerShellEditorServices/Services/Analysis/PssaCmdletAnalysisEngine.cs

@@ -292,10 +292,17 @@ private PowerShellResult InvokePowerShell(PSCommand command)
             catch (CmdletInvocationException ex)
             {
                 // We do not want to crash EditorServices for exceptions caused by cmdlet invocation.
-                // Two main reasons that cause the exception are:
+                // The main reasons that cause the exception are:
                 // * PSCmdlet.WriteOutput being called from another thread than Begin/Process
                 // * CompositionContainer.ComposeParts complaining that "...Only one batch can be composed at a time"
-                _logger.LogError(ex.Message);
+                // * PSScriptAnalyzer not being able to find its PSScriptAnalyzer.psd1 because we are hosted by an Assembly other than pwsh.exe
+                string message = ex.Message;
+                if (!string.IsNullOrEmpty(ex.ErrorRecord.FullyQualifiedErrorId))
+                {
+                    // Microsoft.PowerShell.EditorServices.Services.Analysis.PssaCmdletAnalysisEngine: Exception of type 'System.Exception' was thrown. |
+                    message += $" | {ex.ErrorRecord.FullyQualifiedErrorId}";
+                }
+                _logger.LogError(message);
             }
 
             return result;

src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs

@@ -193,9 +193,9 @@ public PsesInternalHost(
             Version = hostInfo.Version;
 
             DebugContext = new PowerShellDebugContext(loggerFactory, this);
-            UI = hostInfo.ConsoleReplEnabled
-                ? new EditorServicesConsolePSHostUserInterface(loggerFactory, hostInfo.PSHost.UI)
-                : new NullPSHostUI();
+            UI = hostInfo.UseNullPSHostUI
+                ? new NullPSHostUI()
+                : new EditorServicesConsolePSHostUserInterface(loggerFactory, hostInfo.PSHost.UI);
         }
 
         public override CultureInfo CurrentCulture => _hostInfo.PSHost.CurrentCulture;

src/PowerShellEditorServices/Services/PowerShell/Utility/PowerShellExtensions.cs

@@ -12,6 +12,7 @@
 
 namespace Microsoft.PowerShell.EditorServices.Services.PowerShell.Utility
 {
+    using System.Collections;
     using System.Management.Automation;
 
     internal static class PowerShellExtensions
@@ -73,6 +74,10 @@ public static Collection<TResult> InvokeAndClear<TResult>(this PowerShell pwsh,
         {
             try
             {
+                if (pwsh.Runspace.SessionStateProxy.PSVariable.GetValue("error") is ArrayList errors)
+                {
+                    errors.Clear();
+                }
                 return pwsh.Invoke<TResult>(input: null, invocationSettings);
             }
             finally

test/PowerShellEditorServices.Test/PsesHostFactory.cs

@@ -57,6 +57,7 @@ public static PsesInternalHost Create(ILoggerFactory loggerFactory, bool loadPro
                 logLevel: (int)LogLevel.None,
                 consoleReplEnabled: false,
                 usesLegacyReadLine: false,
+                useNullPSHostUI: true, // Preserve previous functionality
                 bundledModulePath: BundledModulePath);
 
             PsesInternalHost psesHost = new(loggerFactory, null, testHostDetails);