Run roslynator fix

With `--ignored-diagnostics CA1067 CS0659 VSTHRD002 VSTHRD100 VSTHRD103 VSTHRD114 VSTHRD200 xUnit1004`

Author: andyleejordan

src/PowerShellEditorServices/Extensions/EditorFileRanges.cs

@@ -37,7 +37,7 @@ public static FileScriptPosition FromOffset(FileContext file, int offset)
 
             if (offset >= fileText.Length)
             {
-                throw new ArgumentException(nameof(offset), "Offset greater than file length");
+                throw new ArgumentException("Offset greater than file length", nameof(offset));
             }
 
             int lastLineOffset = -1;

src/PowerShellEditorServices/Services/Analysis/AnalysisService.cs

@@ -39,17 +39,17 @@ internal static string GetUniqueIdFromDiagnostic(Diagnostic diagnostic)
 
             StringBuilder sb = new StringBuilder(256)
             .Append(diagnostic.Source ?? "?")
-            .Append("_")
+            .Append('_')
             .Append(diagnostic.Code?.IsString ?? true ? diagnostic.Code?.String : diagnostic.Code?.Long.ToString())
-            .Append("_")
+            .Append('_')
             .Append(diagnostic.Severity?.ToString() ?? "?")
-            .Append("_")
+            .Append('_')
             .Append(start.Line)
-            .Append(":")
+            .Append(':')
             .Append(start.Character)
-            .Append("-")
+            .Append('-')
             .Append(end.Line)
-            .Append(":")
+            .Append(':')
             .Append(end.Character);
 
             string id = sb.ToString();
@@ -210,7 +210,7 @@ public async Task<string> GetCommentHelpText(string functionText, string helpLoc
 
             if (analysisResults.Length == 0
                 || analysisResults[0]?.Correction?.Edits == null
-                || analysisResults[0].Correction.Edits.Count() == 0)
+                || analysisResults[0].Correction.Edits.Length == 0)
             {
                 return null;
             }

src/PowerShellEditorServices/Services/PowerShell/Handlers/ExpandAliasHandler.cs

@@ -73,7 +73,7 @@ function __Expand-Alias {
 
             return new ExpandAliasResult
             {
-                Text = result.First()
+                Text = result[0]
             };
         }
     }

src/PowerShellEditorServices/Services/Template/TemplateService.cs

@@ -72,7 +72,7 @@ public async Task<bool> ImportPlasterIfInstalledAsync()
 
                 _logger.LogTrace("Checking if Plaster is installed...");
 
-                PSObject moduleObject = (await _executionService.ExecutePSCommandAsync<PSObject>(psCommand, CancellationToken.None).ConfigureAwait(false)).First();
+                PSObject moduleObject = (await _executionService.ExecutePSCommandAsync<PSObject>(psCommand, CancellationToken.None).ConfigureAwait(false))[0];
 
                 isPlasterInstalled = moduleObject != null;
                 string installedQualifier =
@@ -135,7 +135,7 @@ public async Task<TemplateDetails[]> GetAvailableTemplatesAsync(
                 psCommand,
                 CancellationToken.None).ConfigureAwait(false);
 
-            _logger.LogTrace($"Found {templateObjects.Count()} Plaster templates");
+            _logger.LogTrace($"Found {templateObjects.Count} Plaster templates");
 
             return
                 templateObjects

test/PowerShellEditorServices.Test/Language/TokenOperationsTests.cs

@@ -181,7 +181,7 @@ public void LaguageServiceFindsFoldablRegionsWithCRLF() {
             // The Foldable regions should be the same regardless of line ending type
             // Enforce CRLF line endings, if none exist
             string testString = allInOneScript;
-            if (testString.IndexOf("\r\n") == -1) {
+            if (!testString.Contains("\r\n", StringComparison.CurrentCulture)) {
                 testString = testString.Replace("\n", "\r\n");
             }
             // Ensure that there are CRLF characters in the string

test/PowerShellEditorServices.Test/Session/WorkspaceTests.cs

@@ -128,7 +128,7 @@ public void CanRecurseDirectoryTreeWithLimit()
                 ignoreReparsePoints: s_defaultIgnoreReparsePoints
             );
 
-            Assert.Equal(1, fileList.Count);
+            Assert.Single(fileList);
             Assert.Equal(Path.Combine(workspace.WorkspacePath, "rootfile.ps1"), fileList[0]);
         }