Ignore cancellation of completion requests

andyleejordan · andyleejordan · commit bd119b35e9dd · 2023-05-22T17:09:32.000-07:00
Resolves #4582.
diff --git a/src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs b/src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs
@@ -82,6 +82,11 @@ public override async Task<CompletionList> Handle(CompletionParams request, Canc
                 // (typically files) returned by the space completion
                 return new CompletionList(completionResults, isIncomplete || request?.Context?.TriggerCharacter is " ");
             }
+            // Ignore canceled requests (logging will pollute the output).
+            catch (TaskCanceledException)
+            {
+                return new CompletionList(isIncomplete: true);
+            }
             // We can't do anything about completions failing.
             catch (Exception e)
             {

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,11 @@ public override async Task<CompletionList> Handle(CompletionParams request, Canc`
`82`	`82`	`// (typically files) returned by the space completion`
`83`	`83`	`return new CompletionList(completionResults, isIncomplete \|\| request?.Context?.TriggerCharacter is " ");`
`84`	`84`	`}`
	`85`	`+ // Ignore canceled requests (logging will pollute the output).`
	`86`	`+ catch (TaskCanceledException)`
	`87`	`+ {`
	`88`	`+ return new CompletionList(isIncomplete: true);`
	`89`	`+ }`
`85`	`90`	`// We can't do anything about completions failing.`
`86`	`91`	`catch (Exception e)`
`87`	`92`	`{`