Delete dead internal code

Author: andyleejordan

src/PowerShellEditorServices/Utility/IScriptExtentExtensions.cs

@@ -4,48 +4,14 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Linq.Expressions;
 using System.Management.Automation;
 using System.Management.Automation.Runspaces;
-using System.Reflection;
 using System.Text;
 
 namespace Microsoft.PowerShell.EditorServices.Utility
 {
     internal static class PSCommandHelpers
     {
-        private static readonly Func<CommandInfo, Command> s_commandCtor;
-
-        static PSCommandHelpers()
-        {
-            ConstructorInfo ctor = typeof(Command).GetConstructor(
-                BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.Public,
-                binder: null,
-                new[] { typeof(CommandInfo) },
-                modifiers: null);
-
-            ParameterExpression commandInfo = Expression.Parameter(typeof(CommandInfo), nameof(commandInfo));
-
-            s_commandCtor = Expression.Lambda<Func<CommandInfo, Command>>(
-                Expression.New(ctor, commandInfo),
-                new[] { commandInfo })
-                .Compile();
-        }
-
-        /// <summary>
-        /// PowerShell's missing an API for us to AddCommand using a CommandInfo.
-        /// An issue was filed here: https://github.com/PowerShell/PowerShell/issues/12295
-        /// This works around this by creating a `Command` and passing it into PSCommand.AddCommand(Command command)
-        /// </summary>
-        /// <param name="command"></param>
-        /// <param name="commandInfo"></param>
-        /// <returns></returns>
-        public static PSCommand AddCommand(this PSCommand command, CommandInfo commandInfo)
-        {
-            Command rsCommand = s_commandCtor(commandInfo);
-            return command.AddCommand(rsCommand);
-        }
-
         public static PSCommand AddOutputCommand(this PSCommand psCommand)
         {
             return psCommand.MergePipelineResults()

src/PowerShellEditorServices/Utility/PSCommandExtensions.cs

@@ -10,26 +10,6 @@ namespace Microsoft.PowerShell.EditorServices.Utility
 {
     internal static class PathUtils
     {
-        /// <summary>
-        /// <para>The default path separator used by the base implementation of the providers.</para>
-        /// <para>
-        /// Porting note: IO.Path.DirectorySeparatorChar is correct for all platforms. On Windows,
-        /// it is '\', and on Linux, it is '/', as expected.
-        /// </para>
-        /// </summary>
-        internal static readonly char DefaultPathSeparator = Path.DirectorySeparatorChar;
-
-        /// <summary>
-        /// <para>The alternate path separator used by the base implementation of the providers.</para>
-        /// <para>
-        /// Porting note: we do not use .NET's AlternatePathSeparatorChar here because it correctly
-        /// states that both the default and alternate are '/' on Linux. However, for PowerShell to
-        /// be "slash agnostic", we need to use the assumption that a '\' is the alternate path
-        /// separator on Linux.
-        /// </para>
-        /// </summary>
-        internal static readonly char AlternatePathSeparator = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? '/' : '\\';
-
         /// <summary>
         /// The <see cref="StringComparison" /> value to be used when comparing paths. Will be
         /// <see cref="StringComparison.Ordinal" /> for case sensitive file systems and <see cref="StringComparison.OrdinalIgnoreCase" />
@@ -39,13 +19,6 @@ internal static class PathUtils
             ? StringComparison.Ordinal
             : StringComparison.OrdinalIgnoreCase;
 
-        /// <summary>
-        /// Converts all alternate path separators to the current platform's main path separators.
-        /// </summary>
-        /// <param name="path">The path to normalize.</param>
-        /// <returns>The normalized path.</returns>
-        public static string NormalizePathSeparators(string path) => string.IsNullOrWhiteSpace(path) ? path : path.Replace(AlternatePathSeparator, DefaultPathSeparator);
-
         /// <summary>
         /// Determines whether two specified strings represent the same path.
         /// </summary>
@@ -67,8 +40,8 @@ internal static bool IsPathEqual(string left, string right)
                 return false;
             }
 
-            left = Path.GetFullPath(left).TrimEnd(DefaultPathSeparator);
-            right = Path.GetFullPath(right).TrimEnd(DefaultPathSeparator);
+            left = Path.GetFullPath(left).TrimEnd(Path.DirectorySeparatorChar);
+            right = Path.GetFullPath(right).TrimEnd(Path.DirectorySeparatorChar);
             return left.Equals(right, PathComparison);
         }