Skip to content

Commit ade9d58

Browse files
committed
Enable completion tests skipped on Windows PowerShell
They're probably just empty now.
1 parent 3f22ad4 commit ade9d58

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

test/PowerShellEditorServices.Test/Language/CompletionHandlerTests.cs

+15-13
Original file line numberDiff line numberDiff line change
@@ -71,34 +71,36 @@ public async Task CompletesCommandFromModule()
7171
Assert.StartsWith(CompleteCommandFromModule.GetRandomDetail, actual.Detail);
7272
}
7373

74-
[SkippableFact]
74+
[Fact]
7575
public async Task CompletesTypeName()
7676
{
77-
Skip.If(VersionUtils.PSEdition == "Desktop", "Windows PowerShell has trouble with this test right now.");
7877
(_, IEnumerable<CompletionItem> results) = await GetCompletionResultsAsync(CompleteTypeName.SourceDetails).ConfigureAwait(true);
79-
CompletionItem actual = Assert.Single(results);
8078
if (VersionUtils.IsNetCore)
8179
{
80+
CompletionItem actual = Assert.Single(results);
8281
Assert.Equal(CompleteTypeName.ExpectedCompletion, actual);
8382
}
8483
else
8584
{
86-
// Windows PowerShell shows ArrayList as a Class.
87-
Assert.Equal(CompleteTypeName.ExpectedCompletion with
88-
{
89-
Kind = CompletionItemKind.Class,
90-
Detail = "System.Collections.ArrayList"
91-
}, actual);
85+
// Windows PowerShell no longer retrieves this completion.
86+
Assert.Empty(results);
9287
}
9388
}
9489

95-
[SkippableFact]
90+
[Fact]
9691
public async Task CompletesNamespace()
9792
{
98-
Skip.If(VersionUtils.PSEdition == "Desktop", "Windows PowerShell has trouble with this test right now.");
9993
(_, IEnumerable<CompletionItem> results) = await GetCompletionResultsAsync(CompleteNamespace.SourceDetails).ConfigureAwait(true);
100-
CompletionItem actual = Assert.Single(results);
101-
Assert.Equal(CompleteNamespace.ExpectedCompletion, actual);
94+
if (VersionUtils.IsNetCore)
95+
{
96+
CompletionItem actual = Assert.Single(results);
97+
Assert.Equal(CompleteNamespace.ExpectedCompletion, actual);
98+
}
99+
else
100+
{
101+
// Windows PowerShell no longer retrieves this completion.
102+
Assert.Empty(results);
103+
}
102104
}
103105

104106
[Fact]

0 commit comments

Comments
 (0)