codacy

Author: TylerLeonhardt

src/PowerShellEditorServices/Services/DebugAdapter/BreakpointService.cs

@@ -281,6 +281,8 @@ public async Task RemoveBreakpointsAsync(IEnumerable<Breakpoint> breakpoints)
                                 bps.Remove(lineBreakpoint);
                             }
                             break;
+                        default:
+                            throw new ArgumentException("Unsupported breakpoint type.");
                     }
                 }
 

src/PowerShellEditorServices/Services/DebugAdapter/DebugService.cs

@@ -185,7 +185,7 @@ public async Task<BreakpointDetails[]> SetLineBreakpointsAsync(
             {
                 if (clearExisting)
                 {
-                    await this.ClearBreakpointsInFileAsync(scriptFile).ConfigureAwait(false);
+                    await _breakpointService.RemoveAllBreakpointsAsync(scriptFile.FilePath).ConfigureAwait(false);
                 }
 
                 return (await _breakpointService.SetBreakpointsAsync(escapedScriptPath, breakpoints).ConfigureAwait(false)).ToArray();
@@ -665,23 +665,6 @@ public VariableScope[] GetVariableScopes(int stackFrameId)
 
         #region Private Methods
 
-        private async Task ClearBreakpointsInFileAsync(ScriptFile scriptFile)
-        {
-            // Get the list of breakpoints for this file
-            // if (_breakpointService.BreakpointsPerFile.TryGetValue(scriptFile.Id, out HashSet<Breakpoint> breakpoints))
-            // {
-                // if (breakpoints.Count > 0)
-                // {
-                    await _breakpointService.RemoveAllBreakpointsAsync(scriptFile.FilePath).ConfigureAwait(false);
-                    // await _breakpointService.RemoveBreakpointsAsync((await _breakpointService.GetBreakpointsAsync())
-                    //     .Where(bp => bp is LineBreakpoint lbp && string.Equals(lbp.Script, scriptFile.FilePath))).ConfigureAwait(false);
-
-                    // Clear the existing breakpoints list for the file
-                    // breakpoints.Clear();
-                // }
-            // }
-        }
-
         private async Task FetchStackFramesAndVariablesAsync(string scriptNameOverride)
         {
             await this.debugInfoHandle.WaitAsync().ConfigureAwait(false);

src/PowerShellEditorServices/Services/DebugAdapter/Handlers/BreakpointHandlers.cs

@@ -142,11 +142,12 @@ public SetBreakpointsHandler(
         public async Task<SetBreakpointsResponse> Handle(SetBreakpointsArguments request, CancellationToken cancellationToken)
         {
             ScriptFile scriptFile = null;
+            bool isUntitledPath = ScriptFile.IsUntitledPath(request.Source.Path);
 
             // When you set a breakpoint in the right pane of a Git diff window on a PS1 file,
             // the Source.Path comes through as Untitled-X. That's why we check for IsUntitledPath.
             if (!_workspaceService.TryGetFile(request.Source.Path, out scriptFile) &&
-                !ScriptFile.IsUntitledPath(request.Source.Path))
+                !isUntitledPath)
             {
                 string message = _debugStateService.NoDebug ? string.Empty : "Source file could not be accessed, breakpoint not set.";
                 var srcBreakpoints = request.Breakpoints
@@ -162,7 +163,6 @@ public async Task<SetBreakpointsResponse> Handle(SetBreakpointsArguments request
 
             // Verify source file is a PowerShell script file.
             string fileExtension = Path.GetExtension(scriptFile?.FilePath ?? "")?.ToLower();
-            bool isUntitledPath = ScriptFile.IsUntitledPath(request.Source.Path);
             if ((!isUntitledPath && fileExtension != ".ps1" && fileExtension != ".psm1") ||
                 (!BreakpointApiUtils.SupportsBreakpointApis && isUntitledPath))
             {