Set Console.OutputEncoding to UTF-8

daviwil · daviwil · commit 734cf87aa823 · 2017-03-16T14:15:47.000-07:00
Setting the OutputEncoding to Unicode caused characters to be written
incorrectly in some cases.  UTF-8 is the correct setting.
diff --git a/src/PowerShellEditorServices/Session/SessionPSHostUserInterface.cs b/src/PowerShellEditorServices/Session/SessionPSHostUserInterface.cs
@@ -57,9 +57,9 @@ public ConsoleServicePSHostUserInterface(bool enableConsoleRepl)
         {
             if (enableConsoleRepl)
             {
-                // Set the output encoding to Unicode so that all
-                // Unicode characters are written correctly
-                System.Console.OutputEncoding = System.Text.Encoding.Unicode;
+                // Set the output encoding to UTF-8 so that special
+                // characters are written to the console correctly
+                System.Console.OutputEncoding = System.Text.Encoding.UTF8;
             }
 
             this.rawUserInterface =

Original file line number	Diff line number	Diff line change
`@@ -57,9 +57,9 @@ public ConsoleServicePSHostUserInterface(bool enableConsoleRepl)`
`57`	`57`	`{`
`58`	`58`	`if (enableConsoleRepl)`
`59`	`59`	`{`
`60`		`- // Set the output encoding to Unicode so that all`
`61`		`- // Unicode characters are written correctly`
`62`		`- System.Console.OutputEncoding = System.Text.Encoding.Unicode;`
	`60`	`+ // Set the output encoding to UTF-8 so that special`
	`61`	`+ // characters are written to the console correctly`
	`62`	`+ System.Console.OutputEncoding = System.Text.Encoding.UTF8;`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`this.rawUserInterface =`