Enforce Code Style in Build and Suppress Existing Warnings for Cleaner Build/CI Output

Author: JustinGrote

.editorconfig

@@ -35,9 +35,23 @@ dotnet_diagnostic.CA2016.severity = error
 # All maintainability issues (dead code etc.)
 # See: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/maintainability-warnings
 dotnet_analyzer_diagnostic.category-Maintainability.severity = error
-# VSTHRD002: Synchronously waiting on tasks or awaiters may cause deadlocks
+
+
 # TODO: Fix all of these issues and explicitly ignore the intentional ones.
 dotnet_diagnostic.VSTHRD002.severity = silent
+dotnet_diagnostic.VSTHRD003.severity = silent
+dotnet_diagnostic.VSTHRD105.severity = silent
+dotnet_diagnostic.VSTHRD100.severity = silent
+dotnet_diagnostic.VSTHRD103.severity = silent
+dotnet_diagnostic.VSTHRD110.severity = silent
+dotnet_diagnostic.VSTHRD114.severity = silent
+dotnet_diagnostic.CS0649.severity = silent
+dotnet_diagnostic.CS0618.severity = silent
+dotnet_diagnostic.CS1998.severity = silent
+dotnet_diagnostic.CS4014.severity = silent
+dotnet_diagnostic.xUnit2013.severity = silent
+
+
 # VSTHRD200: Use "Async" suffix for awaitable methods
 dotnet_diagnostic.VSTHRD200.severity = silent
 # IDE0003: this and Me preferences

src/PowerShellEditorServices.Hosting/PowerShellEditorServices.Hosting.csproj

@@ -4,6 +4,7 @@
   <PropertyGroup>
     <TargetFrameworks>netcoreapp3.1;net461</TargetFrameworks>
     <AssemblyName>Microsoft.PowerShell.EditorServices.Hosting</AssemblyName>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
   </PropertyGroup>
 
   <!-- HACK: This is a temporary workaround of `dotnet publish` -->

src/PowerShellEditorServices.VSCode/PowerShellEditorServices.VSCode.csproj

@@ -7,6 +7,7 @@
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
     <AssemblyName>Microsoft.PowerShell.EditorServices.VSCode</AssemblyName>
     <Configurations>Debug;Release;CoreCLR</Configurations>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
   </PropertyGroup>
 
   <!-- Fail the release build if there are missing public API documentation comments -->

src/PowerShellEditorServices/PowerShellEditorServices.csproj

@@ -7,6 +7,7 @@
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
     <AssemblyName>Microsoft.PowerShell.EditorServices</AssemblyName>
     <Configurations>Debug;Release</Configurations>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
   </PropertyGroup>
 
   <ItemGroup>

test/PowerShellEditorServices.Test.E2E/PowerShellEditorServices.Test.E2E.csproj

@@ -4,6 +4,7 @@
   <PropertyGroup>
     <TargetFrameworks>net6.0;netcoreapp3.1</TargetFrameworks>
     <IsPackable>false</IsPackable>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
   </PropertyGroup>
 
   <ItemGroup>

test/PowerShellEditorServices.Test.Shared/PowerShellEditorServices.Test.Shared.csproj

@@ -4,6 +4,7 @@
     <VersionPrefix>0.9.0-beta</VersionPrefix>
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
     <AssemblyName>Microsoft.PowerShell.EditorServices.Test.Shared</AssemblyName>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\..\src\PowerShellEditorServices\PowerShellEditorServices.csproj" />

test/PowerShellEditorServices.Test/PowerShellEditorServices.Test.csproj

@@ -5,6 +5,7 @@
     <TargetFrameworks>net6.0;netcoreapp3.1;net461</TargetFrameworks>
     <AssemblyName>Microsoft.PowerShell.EditorServices.Test</AssemblyName>
     <TargetPlatform>x64</TargetPlatform>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
   </PropertyGroup>
 
   <PropertyGroup>