Allow progress colors to be settable and gettable from the internal host (#1272)

* Allow progress colors to be settable and gettable from internal host

* cosmetic

* rename privatedata to a more descriptive name

* cleaner code

Co-Authored-By: Patrick Meinecke <[email protected]>

* typo in suggestion

* change _internalHostUI back to internalHostUI to try to fix CI

Co-authored-by: Patrick Meinecke <[email protected]>

Author: TylerLeonhardt

src/PowerShellEditorServices/Services/PowerShellContext/Session/Host/EditorServicesPSHostUserInterface.cs

@@ -802,8 +802,8 @@ private void WriteDebuggerBanner(DebuggerStopEventArgs eventArgs)
         internal ConsoleColor VerboseForegroundColor { get; set; } = ConsoleColor.Yellow;
         internal ConsoleColor VerboseBackgroundColor { get; set; } = BackgroundColor;
 
-        internal ConsoleColor ProgressForegroundColor { get; set; } = ConsoleColor.Yellow;
-        internal ConsoleColor ProgressBackgroundColor { get; set; } = ConsoleColor.DarkCyan;
+        internal virtual ConsoleColor ProgressForegroundColor { get; set; } = ConsoleColor.Yellow;
+        internal virtual ConsoleColor ProgressBackgroundColor { get; set; } = ConsoleColor.DarkCyan;
 
         private async Task StartReplLoopAsync(CancellationToken cancellationToken)
         {

src/PowerShellEditorServices/Services/PowerShellContext/Session/Host/TerminalPSHostUserInterface.cs

@@ -22,7 +22,8 @@ internal class TerminalPSHostUserInterface : EditorServicesPSHostUserInterface
         #region Private Fields
 
         private readonly PSHostUserInterface internalHostUI;
-        private ConsoleReadLine consoleReadLine;
+        private readonly PSObject _internalHostPrivateData;
+        private readonly ConsoleReadLine _consoleReadLine;
 
         #endregion
 
@@ -44,8 +45,9 @@ public TerminalPSHostUserInterface(
                 new TerminalPSHostRawUserInterface(logger, internalHost),
                 logger)
         {
-            this.internalHostUI = internalHost.UI;
-            this.consoleReadLine = new ConsoleReadLine(powerShellContext);
+            internalHostUI = internalHost.UI;
+            _internalHostPrivateData = internalHost.PrivateData;
+            _consoleReadLine = new ConsoleReadLine(powerShellContext);
 
             // Set the output encoding to UTF-8 so that special
             // characters are written to the console correctly
@@ -54,11 +56,11 @@ public TerminalPSHostUserInterface(
             System.Console.CancelKeyPress +=
                 (obj, args) =>
                 {
-                    if (!this.IsNativeApplicationRunning)
+                    if (!IsNativeApplicationRunning)
                     {
                         // We'll handle Ctrl+C
                         args.Cancel = true;
-                        this.SendControlC();
+                        SendControlC();
                     }
                 };
         }
@@ -75,6 +77,24 @@ public TerminalPSHostUserInterface(
         /// </summary>
         internal protected override bool SupportsWriteProgress => true;
 
+        /// <summary>
+        /// Gets and sets the value of progress foreground from the internal host since Progress is handled there.
+        /// </summary>
+        internal override ConsoleColor ProgressForegroundColor
+        {
+            get => (ConsoleColor)_internalHostPrivateData.Properties["ProgressForegroundColor"].Value;
+            set => _internalHostPrivateData.Properties["ProgressForegroundColor"].Value = value;
+        }
+
+        /// <summary>
+        /// Gets and sets the value of progress background from the internal host since Progress is handled there.
+        /// </summary>
+        internal override ConsoleColor ProgressBackgroundColor
+        {
+            get => (ConsoleColor)_internalHostPrivateData.Properties["ProgressBackgroundColor"].Value;
+            set => _internalHostPrivateData.Properties["ProgressBackgroundColor"].Value = value;
+        }
+
         /// <summary>
         /// Requests that the HostUI implementation read a command line
         /// from the user to be executed in the integrated console command
@@ -86,7 +106,7 @@ public TerminalPSHostUserInterface(
         /// <returns>A Task that can be awaited for the resulting input string.</returns>
         protected override Task<string> ReadCommandLineAsync(CancellationToken cancellationToken)
         {
-            return this.consoleReadLine.ReadCommandLineAsync(cancellationToken);
+            return _consoleReadLine.ReadCommandLineAsync(cancellationToken);
         }
 
         /// <summary>
@@ -97,9 +117,9 @@ protected override Task<string> ReadCommandLineAsync(CancellationToken cancellat
         protected override InputPromptHandler OnCreateInputPromptHandler()
         {
             return new TerminalInputPromptHandler(
-                this.consoleReadLine,
+                _consoleReadLine,
                 this,
-                this.Logger);
+                Logger);
         }
 
         /// <summary>
@@ -110,9 +130,9 @@ protected override InputPromptHandler OnCreateInputPromptHandler()
         protected override ChoicePromptHandler OnCreateChoicePromptHandler()
         {
             return new TerminalChoicePromptHandler(
-                this.consoleReadLine,
+                _consoleReadLine,
                 this,
-                this.Logger);
+                Logger);
         }
 
         /// <summary>
@@ -167,7 +187,7 @@ public override void WriteOutput(
         /// </param>
         protected override void WriteProgressImpl(long sourceId, ProgressRecord record)
         {
-            this.internalHostUI.WriteProgress(sourceId, record);
+            internalHostUI.WriteProgress(sourceId, record);
         }
 
         /// <summary>