(todo) Working!

Author: glennsarti

PowerShellEditorServices.build.ps1

@@ -51,12 +51,14 @@ Schema is:
 }
 #>
 $script:RequiredBuildAssets = @{
+    # TODO: Add glob.cs.dll
     $script:ModuleBinPath = @{
         'PowerShellEditorServices' = @(
             'publish/Serilog.dll',
             'publish/Serilog.Sinks.Async.dll',
             'publish/Serilog.Sinks.Console.dll',
             'publish/Serilog.Sinks.File.dll',
+            'publish/Microsoft.Extensions.FileSystemGlobbing.dll',
             'Microsoft.PowerShell.EditorServices.dll',
             'Microsoft.PowerShell.EditorServices.pdb'
         )

src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs

@@ -725,6 +725,9 @@ await this.RunScriptDiagnosticsAsync(
             }
         }
 
+        // NEED TO CHECK FILE GLOBBING HERE!!
+        // This is the handler for textDocument/definition - https://microsoft.github.io/language-server-protocol/specification#textDocument_definition
+        // It searches the workspace for a function reference, which is then used as the definition
         protected async Task HandleDefinitionRequestAsync(
             TextDocumentPositionParams textDocumentPosition,
             RequestContext<Location[]> requestContext)
@@ -748,6 +751,7 @@ protected async Task HandleDefinitionRequestAsync(
                     await editorSession.LanguageService.GetDefinitionOfSymbolAsync(
                         scriptFile,
                         foundSymbol,
+                        // Probably something here...
                         editorSession.Workspace);
 
                 if (definition != null)
@@ -764,6 +768,9 @@ await editorSession.LanguageService.GetDefinitionOfSymbolAsync(
             await requestContext.SendResultAsync(definitionLocations.ToArray());
         }
 
+        // NEED TO CHECK FILE GLOBBING HERE!!
+        // This is the handler for textDocument/References - https://microsoft.github.io/language-server-protocol/specification#textDocument_references
+        // It searches the workspace for a function reference
         protected async Task HandleReferencesRequestAsync(
             ReferencesParams referencesParams,
             RequestContext<Location[]> requestContext)
@@ -781,7 +788,9 @@ protected async Task HandleReferencesRequestAsync(
             FindReferencesResult referencesResult =
                 await editorSession.LanguageService.FindReferencesOfSymbolAsync(
                     foundSymbol,
+                    // Probably something here...
                     editorSession.Workspace.ExpandScriptReferences(scriptFile),
+                    // Probably something here...
                     editorSession.Workspace);
 
             Location[] referenceLocations = s_emptyLocationResult;

src/PowerShellEditorServices/Language/LanguageService.cs

@@ -337,6 +337,7 @@ public async Task<FindReferencesResult> FindReferencesOfSymbolAsync(
                 fileMap[scriptFile.FilePath] = scriptFile;
             }
 
+            // Probably something here...
             foreach (string filePath in workspace.EnumeratePSFiles())
             {
                 if (!fileMap.Contains(filePath))
@@ -451,6 +452,7 @@ public async Task<GetDefinitionResult> GetDefinitionOfSymbolAsync(
             if (foundDefinition == null)
             {
                 // Get a list of all powershell files in the workspace path
+                // Probably something here...
                 IEnumerable<string> allFiles = workspace.EnumeratePSFiles();
                 foreach (string file in allFiles)
                 {

src/PowerShellEditorServices/PowerShellEditorServices.csproj

@@ -20,6 +20,7 @@
     <PackageReference Include="Serilog.Sinks.File" Version="4.0.0" />
     <PackageReference Include="Serilog.Sinks.Async" Version="1.3.0" />
     <PackageReference Include="System.Runtime.Extensions" Version="4.3.0" />
+    <PackageReference Include="Microsoft.Extensions.FileSystemGlobbing" Version="2.2.0" />
     <PackageReference Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.3.0" />
   </ItemGroup>
   <PropertyGroup Condition=" '$(Configuration)' == 'Release' ">