Skip to content

Commit 3602eec

Browse files
Remove /p:UseSharedCompilation=false injection (#1938)
This was introduced in f234a8e to workaround an upstream bug in `dotnet`. That issue has since been fixed and released (so this flag is auto-injected), hence we can remove it.
1 parent 9ad772a commit 3602eec

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

PowerShellEditorServices.build.ps1

+4-5
Original file line numberDiff line numberDiff line change
@@ -161,16 +161,15 @@ Task SetupHelpForTests {
161161
}
162162

163163
Task Build FindDotNet, CreateBuildInfo, {
164-
# NOTE: We use /p:UseSharedCompilation=false to work around a bug with CodeQL.
165164
Exec { & dotnet restore $VerbosityArgs }
166-
Exec { & dotnet publish /p:UseSharedCompilation=false $VerbosityArgs -c $Configuration .\src\PowerShellEditorServices\PowerShellEditorServices.csproj -f $script:NetRuntime.Standard }
167-
Exec { & dotnet publish /p:UseSharedCompilation=false $VerbosityArgs -c $Configuration .\src\PowerShellEditorServices.Hosting\PowerShellEditorServices.Hosting.csproj -f $script:NetRuntime.PS7 }
165+
Exec { & dotnet publish $VerbosityArgs -c $Configuration .\src\PowerShellEditorServices\PowerShellEditorServices.csproj -f $script:NetRuntime.Standard }
166+
Exec { & dotnet publish $VerbosityArgs -c $Configuration .\src\PowerShellEditorServices.Hosting\PowerShellEditorServices.Hosting.csproj -f $script:NetRuntime.PS7 }
168167
if (-not $script:IsNix) {
169-
Exec { & dotnet publish /p:UseSharedCompilation=false $VerbosityArgs -c $Configuration .\src\PowerShellEditorServices.Hosting\PowerShellEditorServices.Hosting.csproj -f $script:NetRuntime.Desktop }
168+
Exec { & dotnet publish $VerbosityArgs -c $Configuration .\src\PowerShellEditorServices.Hosting\PowerShellEditorServices.Hosting.csproj -f $script:NetRuntime.Desktop }
170169
}
171170

172171
# Build PowerShellEditorServices.VSCode module
173-
Exec { & dotnet publish /p:UseSharedCompilation=false $VerbosityArgs -c $Configuration .\src\PowerShellEditorServices.VSCode\PowerShellEditorServices.VSCode.csproj -f $script:NetRuntime.Standard }
172+
Exec { & dotnet publish $VerbosityArgs -c $Configuration .\src\PowerShellEditorServices.VSCode\PowerShellEditorServices.VSCode.csproj -f $script:NetRuntime.Standard }
174173
}
175174

176175
Task Test TestServer, TestE2E

0 commit comments

Comments
 (0)