Skip to content

Commit 358dd07

Browse files
Fix silent failure by using Id for dictionary since multiple pages could have the same title (#947)
* Use Id for dictionary since multiple pages could have the same title * codacy got me
1 parent 3b9197d commit 358dd07

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/PowerShellEditorServices.VSCode/CustomViews/CustomViewFeature.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,20 @@ internal abstract class CustomViewFeatureBase<TView>
1616
{
1717
protected IMessageSender messageSender;
1818
protected ILogger logger;
19-
private Dictionary<string, TView> viewIndex;
19+
private readonly Dictionary<Guid, TView> viewIndex;
2020

2121
public CustomViewFeatureBase(
2222
IMessageSender messageSender,
2323
ILogger logger)
2424
{
25-
this.viewIndex = new Dictionary<string, TView>();
25+
this.viewIndex = new Dictionary<Guid, TView>();
2626
this.messageSender = messageSender;
2727
this.logger = logger;
2828
}
2929

3030
protected void AddView(TView view)
3131
{
32-
this.viewIndex.Add(view.Title, view);
32+
this.viewIndex.Add(view.Id, view);
3333
}
3434
}
3535
}

0 commit comments

Comments
 (0)