Apply Roslynator fixups via CLI tool

It's far from perfect.

Author: andyleejordan

src/PowerShellEditorServices.Hosting/Commands/StartEditorServicesCommand.cs

@@ -8,7 +8,6 @@
 using System.Linq;
 using System.Management.Automation;
 using System.Reflection;
-using SMA = System.Management.Automation;
 using System.Management.Automation.Runspaces;
 using Microsoft.PowerShell.EditorServices.Hosting;
 using System.Globalization;
@@ -316,7 +315,7 @@ private string GetLogDirPath()
         private void RemovePSReadLineForStartup()
         {
             _logger.Log(PsesLogLevel.Verbose, "Removing PSReadLine");
-            using (var pwsh = SMA.PowerShell.Create(RunspaceMode.CurrentRunspace))
+            using (var pwsh = System.Management.Automation.PowerShell.Create(RunspaceMode.CurrentRunspace))
             {
                 bool hasPSReadLine = pwsh.AddCommand(new CmdletInfo("Microsoft.PowerShell.Core\\Get-Module", typeof(GetModuleCommand)))
                     .AddParameter("Name", "PSReadLine")

src/PowerShellEditorServices/Extensions/EditorFileRanges.cs

@@ -37,7 +37,7 @@ public static FileScriptPosition FromOffset(FileContext file, int offset)
 
             if (offset >= fileText.Length)
             {
-                throw new ArgumentException(nameof(offset), "Offset greater than file length");
+                throw new ArgumentException("Offset greater than file length", nameof(offset));
             }
 
             int lastLineOffset = -1;

src/PowerShellEditorServices/Logging/PsesTelemetryEvent.cs

@@ -14,26 +14,14 @@ internal class PsesTelemetryEvent : Dictionary<string, object>
     {
         public string EventName
         {
-            get
-            {
-                return this["EventName"].ToString() ?? "PsesEvent";
-            }
-            set
-            {
-                this["EventName"] = value;
-            }
+            get => this["EventName"].ToString() ?? "PsesEvent";
+            set => this["EventName"] = value;
         }
 
         public JObject Data
         {
-            get
-            {
-                return this["Data"] as JObject ?? new JObject();
-            }
-            set
-            {
-                this["Data"] = value;
-            }
+            get => this["Data"] as JObject ?? new JObject();
+            set => this["Data"] = value;
         }
     }
 }

src/PowerShellEditorServices/Services/Analysis/AnalysisService.cs

@@ -39,17 +39,17 @@ internal static string GetUniqueIdFromDiagnostic(Diagnostic diagnostic)
 
             var sb = new StringBuilder(256)
             .Append(diagnostic.Source ?? "?")
-            .Append("_")
+            .Append('_')
             .Append(diagnostic.Code?.IsString ?? true ? diagnostic.Code?.String : diagnostic.Code?.Long.ToString())
-            .Append("_")
+            .Append('_')
             .Append(diagnostic.Severity?.ToString() ?? "?")
-            .Append("_")
+            .Append('_')
             .Append(start.Line)
-            .Append(":")
+            .Append(':')
             .Append(start.Character)
-            .Append("-")
+            .Append('-')
             .Append(end.Line)
-            .Append(":")
+            .Append(':')
             .Append(end.Character);
 
             var id = sb.ToString();
@@ -208,14 +208,11 @@ public async Task<string> GetCommentHelpText(string functionText, string helpLoc
 
             ScriptFileMarker[] analysisResults = await AnalysisEngine.AnalyzeScriptAsync(functionText, commentHelpSettings).ConfigureAwait(false);
 
-            if (analysisResults.Length == 0
-                || analysisResults[0]?.Correction?.Edits == null
-                || analysisResults[0].Correction.Edits.Count() == 0)
-            {
-                return null;
-            }
-
-            return analysisResults[0].Correction.Edits[0].Text;
+            return analysisResults.Length is 0
+                || analysisResults[0]?.Correction?.Edits is null
+                || analysisResults[0].Correction.Edits.Length is 0
+                ? null
+                : analysisResults[0].Correction.Edits[0].Text;
         }
 
         /// <summary>

src/PowerShellEditorServices/Services/Template/TemplateService.cs

@@ -72,7 +72,7 @@ public async Task<bool> ImportPlasterIfInstalledAsync()
 
                 this._logger.LogTrace("Checking if Plaster is installed...");
 
-                PSObject moduleObject = (await _executionService.ExecutePSCommandAsync<PSObject>(psCommand, CancellationToken.None).ConfigureAwait(false)).First();
+                PSObject moduleObject = (await _executionService.ExecutePSCommandAsync<PSObject>(psCommand, CancellationToken.None).ConfigureAwait(false))[0];
 
                 this.isPlasterInstalled = moduleObject != null;
                 string installedQualifier =
@@ -135,7 +135,7 @@ public async Task<TemplateDetails[]> GetAvailableTemplatesAsync(
                 psCommand,
                 CancellationToken.None).ConfigureAwait(false);
 
-            this._logger.LogTrace($"Found {templateObjects.Count()} Plaster templates");
+            this._logger.LogTrace($"Found {templateObjects.Count} Plaster templates");
 
             return
                 templateObjects

test/PowerShellEditorServices.Test/Session/WorkspaceTests.cs

@@ -128,7 +128,7 @@ public void CanRecurseDirectoryTreeWithLimit()
                 ignoreReparsePoints: s_defaultIgnoreReparsePoints
             );
 
-            Assert.Equal(1, fileList.Count);
+            Assert.Single(fileList);
             Assert.Equal(Path.Combine(workspace.WorkspacePath, "rootfile.ps1"), fileList[0]);
         }