Created internal overload for CreateRunspace that accepts InitialSessionState.

Renamed initialRunspace to runspace
Typecasted AdditionalModules instead of using .ToArray() to prevent cannot convert from 'System.Collections.Generic.IReadOnlyList<string>' to 'System.Collections.Generic.IEnumerable<Microsoft.PowerShell.Commands.ModuleSpecification>' compile time error.
This is not ready to be merged as it needs to be rebased on master to fix test issues, and the primary objective of the changes has not been met as  CommandCompletion.CompleteInput returns 0 CompletionResults when spawned from a Constrained Runspace. This may or may not require a fix from the PowerShell team as we are spawning CompleteInput from an overload of CompleteCommand that uses TabExpansion2 and there is a comment in their code indicating that this (or something related to it) is currently broken: https://github.com/PowerShell/PowerShell/blob/f4382202ae4622bf26795e29a7b39b9d7cdfb3fb/src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs#L547

Author: dkattan

src/PowerShellEditorServices.Hosting/Commands/StartEditorServicesCommand.cs

@@ -351,6 +351,7 @@ private EditorServicesConfig CreateConfigObject()
             var profile = (PSObject)GetVariableValue("profile");
 
             var hostInfo = new HostInfo(HostName, HostProfileId, HostVersion);
+            // This ensures that all Runspaces are created with the same InitialSessionState as the runspace that started EditorServices
             var initialSessionState = Runspace.DefaultRunspace.InitialSessionState;
             var editorServicesConfig = new EditorServicesConfig(hostInfo, Host, SessionDetailsPath, bundledModulesPath, LogPath)
             {

src/PowerShellEditorServices/PowerShellEditorServices.csproj

@@ -55,8 +55,4 @@
   <ItemGroup>
     <Compile Remove="Extensions\Api\DocumentSymbolService.cs" />
   </ItemGroup>
-
-  <ItemGroup>
-    <Folder Include="Properties\" />
-  </ItemGroup>
 </Project>

src/PowerShellEditorServices/Services/PowerShellContext/PowerShellContextService.cs

@@ -215,11 +215,11 @@ public static PowerShellContextService Create(
 
             if (hostStartupInfo.InitialSessionState.LanguageMode != PSLanguageMode.FullLanguage)
             {
-                hostStartupInfo.InitialSessionState.ImportPSModule(hostStartupInfo.AdditionalModules.ToArray());
+                hostStartupInfo.InitialSessionState.ImportPSModule((IEnumerable<Commands.ModuleSpecification>)hostStartupInfo.AdditionalModules);
                 hostStartupInfo.InitialSessionState.ImportPSModule(new string[] { s_commandsModulePath });
             }
-            Runspace initialRunspace = PowerShellContextService.CreateRunspace(psHost, hostStartupInfo.InitialSessionState);
-            powerShellContext.Initialize(hostStartupInfo.ProfilePaths, initialRunspace, true, hostUserInterface);
+            Runspace runspace = PowerShellContextService.CreateRunspace(psHost, hostStartupInfo.InitialSessionState);
+            powerShellContext.Initialize(hostStartupInfo.ProfilePaths, runspace, true, hostUserInterface);
             // TODO: This can be moved to the point after the $psEditor object
             // gets initialized when that is done earlier than LanguageServer.Initialize
             // Darren Kattan: I haven't tested it, but I have a feeling this entire bit of logic can be replaced with the bit above for non-FullLanguage mode. I think that was is cleaner anyway.            
@@ -267,26 +267,15 @@ public static Runspace CreateRunspace(
             powerShellContext.ConsoleReader = hostUserInterface;
             return CreateRunspace(psHost, hostDetails.InitialSessionState);
         }
-        
+
         /// <summary>
         ///
         /// </summary>
         /// <param name="psHost">The PSHost that will be used for this Runspace.</param>
         /// <param name="initialSessionState">The initialSessionState inherited from the orginal PowerShell process. This will be used when creating runspaces so that we honor the same initialSessionState including allowed modules, cmdlets and language mode.</param>
         /// <returns></returns>
-        public static Runspace CreateRunspace(PSHost psHost, InitialSessionState initialSessionState)
+        internal static Runspace CreateRunspace(PSHost psHost, InitialSessionState initialSessionState)
         {
-            if (initialSessionState == null)
-            {
-                if (Environment.GetEnvironmentVariable("PSES_TEST_USE_CREATE_DEFAULT") == "1")
-                {
-                    initialSessionState = InitialSessionState.CreateDefault();
-                }
-                else
-                {
-                    initialSessionState = InitialSessionState.CreateDefault2();
-                }
-            }
             Runspace runspace = RunspaceFactory.CreateRunspace(psHost, initialSessionState);
 
             // Windows PowerShell must be hosted in STA mode
@@ -301,6 +290,24 @@ public static Runspace CreateRunspace(PSHost psHost, InitialSessionState initial
 
             return runspace;
         }
+        /// <summary>
+        ///
+        /// </summary>
+        /// <param name="psHost">The PSHost that will be used for this Runspace.</param>
+        /// <returns>Runspace object created from the specified PSHost</returns>
+        public static Runspace CreateRunspace(PSHost psHost)
+        {
+            InitialSessionState initialSessionState;
+            if (Environment.GetEnvironmentVariable("PSES_TEST_USE_CREATE_DEFAULT") == "1")
+            {
+                initialSessionState = InitialSessionState.CreateDefault();
+            }
+            else
+            {
+                initialSessionState = InitialSessionState.CreateDefault2();
+            }
+            return CreateRunspace(psHost, initialSessionState);
+        }
 
         /// <summary>
         /// Initializes a new instance of the PowerShellContext class using