Guard expansion of PSPropertyInfo.Value

Which fixes our test that gets the properties of a process object, since
the value for `ExitCode` fails (as the process hasn't ended), we now
handle that a bit more gracefully and can get all 130 properties.

Author: andyleejordan

src/PowerShellEditorServices/Services/DebugAdapter/Debugging/VariableDetails.cs

@@ -68,7 +68,7 @@ public VariableDetails(PSObject psVariableObject)
         /// The PSPropertyInfo instance from which variable details will be obtained.
         /// </param>
         public VariableDetails(PSPropertyInfo psProperty)
-            : this(psProperty.Name, psProperty.Value)
+            : this(psProperty.Name, SafeGetValue(psProperty))
         {
         }
 
@@ -113,6 +113,20 @@ public override VariableDetailsBase[] GetChildren(ILogger logger)
 
         #region Private Methods
 
+        private static object SafeGetValue(PSPropertyInfo psProperty)
+        {
+            try
+            {
+                return psProperty.Value;
+            }
+            catch (GetValueInvocationException ex)
+            {
+                // Sometimes we can't get the value, like ExitCode, for reasons beyond our control,
+                // so just return the message from the exception that arises.
+                return ex.Message;
+            }
+        }
+
         private static bool GetIsExpandable(object valueObject)
         {
             if (valueObject == null)

test/PowerShellEditorServices.Test.Shared/Debugging/GetChildItemTest.ps1

@@ -0,0 +1,2 @@
+$file = Get-ChildItem -Path "." | Select-Object -First 1
+Write-Host "Debug over"

test/PowerShellEditorServices.Test/Debugging/DebugServiceTests.cs

@@ -1078,8 +1078,8 @@ await debugService.SetLineBreakpointsAsync(
 
         // Verifies fix for issue #86, $proc = Get-Process foo displays just the ETS property set
         // and not all process properties.
-        [Fact(Skip = "Length of child vars is wrong now")]
-        public async Task DebuggerVariableProcessObjDisplaysCorrectly()
+        [Fact]
+        public async Task DebuggerVariableProcessObjectDisplaysCorrectly()
         {
             await debugService.SetLineBreakpointsAsync(
                 variableScriptFile,
@@ -1098,7 +1098,31 @@ await debugService.SetLineBreakpointsAsync(
             Assert.True(var.IsExpandable);
 
             VariableDetailsBase[] childVars = await debugService.GetVariables(var.Id, CancellationToken.None).ConfigureAwait(true);
-            Assert.Equal(53, childVars.Length);
+            Assert.Contains(childVars, i => i.Name is "Name" && i.ValueString is "\"dotnet\"");
+            Assert.Contains(childVars, i => i.Name is "Handles");
+            Assert.Contains(childVars, i => i.Name is "CommandLine");
+            Assert.Contains(childVars, i => i.Name is "ExitCode");
+            Assert.Contains(childVars, i => i.Name is "HasExited" && i.ValueString is "$false");
+            Assert.Contains(childVars, i => i.Name is "Id" && i.Type is "[System.Int32]");
+        }
+
+        [Fact]
+        public async Task DebuggerVariableFileObjectDisplaysCorrectly()
+        {
+            await debugService.SetCommandBreakpointsAsync(
+                new[] { CommandBreakpointDetails.Create("Write-Host") }).ConfigureAwait(true);
+
+            ScriptFile testScript = GetDebugScript("GetChildItemTest.ps1");
+            Task _ = ExecuteScriptFileAsync(testScript.FilePath);
+            AssertDebuggerStopped(testScript.FilePath, 2);
+
+            VariableDetailsBase[] variables = await GetVariables(VariableContainerDetails.LocalScopeName).ConfigureAwait(true);
+            VariableDetailsBase var = Array.Find(variables, v => v.Name == "$file");
+            VariableDetailsBase[] childVars = await debugService.GetVariables(var.Id, CancellationToken.None).ConfigureAwait(true);
+            Assert.Contains(childVars, i => i.Name is "PSPath");
+            Assert.Contains(childVars, i => i.Name is "PSProvider" && i.ValueString is "Microsoft.PowerShell.Core\\FileSystem");
+            Assert.Contains(childVars, i => i.Name is "Exists" && i.ValueString is "$true");
+            Assert.Contains(childVars, i => i.Name is "LastAccessTime");
         }
     }
 }