Skip to content

PSScriptAnalyzer rule documentation files should be named consistently with the rules #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewducker opened this issue Mar 17, 2017 · 5 comments

Comments

@andrewducker
Copy link

I'n using PSScriptAnalyzer from inside VSCode, and there doesn't seem to be any documentation of what each rule does, which makes it very hard to decide whether to enable one or not.

Is there a page somewhere which tells me what (for instance) PSAvoidShouldContinueWithoutForce means, so that I can make an informed decision whether to enable that rule?

@daviwil
Copy link
Contributor

daviwil commented Mar 17, 2017

The rule documentation files are here, just look for the filename without the PS prefix:

https://github.com/PowerShell/PSScriptAnalyzer/tree/development/RuleDocumentation

@andrewducker
Copy link
Author

Interesting. The documentation there doesn't cover PSAvoidShouldContinueWithoutForce or AvoidUsingCmdletAliases - both of which are in the VSCode addon (v0.10.1)

Is there some renaming going on between VSCode and PSScriptAnalyzer? Or is VSCode just running behind on the version of PSScriptAnalyzer it uses?

@daviwil
Copy link
Contributor

daviwil commented Mar 17, 2017

I think the documentation could be a little out of date, the PowerShell extension is using 1.11.0 of PSScriptAnalyzer. The AvoidUsingCmdletAliases documentation is here:

https://github.com/PowerShell/PSScriptAnalyzer/blob/development/RuleDocumentation/AvoidAlias.md

The PSAvoidShouldContinueWithoutForce is here, but it's named without the PS:

https://github.com/PowerShell/PSScriptAnalyzer/blob/development/RuleDocumentation/AvoidShouldContinueWithoutForce.md

We definitely need to do a review to make sure the documentation naming is correct.

@daviwil daviwil changed the title No documentation of PSScriptAnalyzer rules PSScriptAnalyzer rule documentation files should be named consistently with the rules Mar 17, 2017
@juneb
Copy link
Contributor

juneb commented Mar 31, 2017

This is a dup of #729.

@kapilmb
Copy link

kapilmb commented Apr 3, 2017

Fixed in #742

@kapilmb kapilmb closed this as completed Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants