fix functionDefinition Ast in cmdlet rule

Maria Romero · Maria Romero · commit bd3bbb936b32 · 2018-05-09T15:40:44.000-07:00
diff --git a/Rules/UseCompatibleCmdlets.cs b/Rules/UseCompatibleCmdlets.cs
@@ -114,10 +114,9 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
             IEnumerable<Ast> functionDefinitionAsts = ast.FindAll(testAst => testAst is FunctionDefinitionAst, true);
             foreach (Ast functionDefinition in functionDefinitionAsts)
             {
-                string function = functionDefinition.GetType().GetProperty("Name").GetValue(functionDefinition).ToString();
-                customCommands.Add(function);
+                FunctionDefinitionAst definition = (FunctionDefinitionAst)functionDefinition;
+                customCommands.Add(definition.Name);
             }
-
             // If we have no cmdlets to check, we can exit from this rule.
             if (commandAsts.Count() == 0)
             {

Original file line number	Diff line number	Diff line change
`@@ -114,10 +114,9 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)`
`114`	`114`	`IEnumerable<Ast> functionDefinitionAsts = ast.FindAll(testAst => testAst is FunctionDefinitionAst, true);`
`115`	`115`	`foreach (Ast functionDefinition in functionDefinitionAsts)`
`116`	`116`	`{`
`117`		`- string function = functionDefinition.GetType().GetProperty("Name").GetValue(functionDefinition).ToString();`
`118`		`- customCommands.Add(function);`
	`117`	`+ FunctionDefinitionAst definition = (FunctionDefinitionAst)functionDefinition;`
	`118`	`+ customCommands.Add(definition.Name);`
`119`	`119`	`}`
`120`		`-`
`121`	`120`	`// If we have no cmdlets to check, we can exit from this rule.`
`122`	`121`	`if (commandAsts.Count() == 0)`
`123`	`122`	`{`