Compare whitelisted aliases in a case-insensitive manner

Kapil Borle · Kapil Borle · commit b050102a066a · 2017-03-29T15:08:39.000-07:00
diff --git a/Rules/AvoidAlias.cs b/Rules/AvoidAlias.cs
@@ -18,6 +18,7 @@
 using System.ComponentModel.Composition;
 #endif
 using System.Globalization;
+using System.Linq;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
 {
@@ -119,7 +120,7 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
                 // You can also review the remark section in following document,
                 // MSDN: CommandAst.GetCommandName Method
                 if (aliasName == null
-                    || whiteList.Contains(aliasName))
+                    || whiteList.Contains<string>(aliasName, StringComparer.OrdinalIgnoreCase))
                 {
                     continue;
                 }

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@`
`18`	`18`	`using System.ComponentModel.Composition;`
`19`	`19`	`#endif`
`20`	`20`	`using System.Globalization;`
	`21`	`+using System.Linq;`
`21`	`22`
`22`	`23`	`namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules`
`23`	`24`	`{`
`@@ -119,7 +120,7 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)`
`119`	`120`	`// You can also review the remark section in following document,`
`120`	`121`	`// MSDN: CommandAst.GetCommandName Method`
`121`	`122`	`if (aliasName == null`
`122`		`- \|\| whiteList.Contains(aliasName))`
	`123`	`+ \|\| whiteList.Contains<string>(aliasName, StringComparer.OrdinalIgnoreCase))`
`123`	`124`	`{`
`124`	`125`	`continue;`
`125`	`126`	`}`