Merge pull request #560 from Blackbaud-ShaydeNofziger/development

Fix typo in PSUseDeclaredVarsMoreThanAssigments rule name

Author: Kapil Borle

Engine/about_PSScriptAnalyzer.help.txt

@@ -134,14 +134,14 @@ RUNNING SCRIPT ANALYZER ON AN EXISTING SCRIPT, MODULE OR DSC RESOURCE
         Count Name
         ----- ----
            23 PSAvoidUsingInvokeExpression
-            8 PSUseDeclaredVarsMoreThanAssigments
+            8 PSUseDeclaredVarsMoreThanAssignments
             8 PSProvideDefaultParameterValue
             6 PSAvoidUninitializedVariable
             3 PSPossibleIncorrectComparisonWithNull
             1 PSAvoidUsingComputerNameHardcoded
 
         You may decide to exclude the PSAvoidUsingInvokeExpression rule for the moment
-        and focus on the rest, especially the PSUseDeclaredVarsMoreThanAssigments, 
+        and focus on the rest, especially the PSUseDeclaredVarsMoreThanAssignments, 
         PSAvoidUninitializedVariable and PSPossibleIncorrectComparisonWithNull rules.
 
         As you fix rules, go back and enable more rules as you have time to address 

Rules/Strings.Designer.cs

@@ -445,7 +445,7 @@
     <value>UseApprovedVerbs</value>
   </data>
   <data name="UseDeclaredVarsMoreThanAssignmentsName" xml:space="preserve">
-    <value>UseDeclaredVarsMoreThanAssigments</value>
+    <value>UseDeclaredVarsMoreThanAssignments</value>
   </data>
   <data name="UsePSCredentialTypeName" xml:space="preserve">
     <value>UsePSCredentialType</value>
@@ -822,4 +822,4 @@
   <data name="UseToExportFieldsInManifestCorrectionDescription" xml:space="preserve">
     <value>Replace {0} with {1}</value>
   </data>
-</root>
+</root>

Rules/Strings.resx

@@ -20,10 +20,10 @@
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
 {
     /// <summary>
-    /// UseDeclaredVarsMoreThanAssigments: Analyzes the ast to check that variables are used in more than just their assignment.
+    /// UseDeclaredVarsMoreThanAssignments: Analyzes the ast to check that variables are used in more than just their assignment.
     /// </summary>
     [Export(typeof(IScriptRule))]
-    public class UseDeclaredVarsMoreThanAssigments : IScriptRule
+    public class UseDeclaredVarsMoreThanAssignments : IScriptRule
     {
         /// <summary>
         /// AnalyzeScript: Analyzes the ast to check that variables are used in more than just there assignment.

Rules/UseDeclaredVarsMoreThanAssignments.cs

@@ -1,6 +1,6 @@
 Import-Module PSScriptAnalyzer
 $violationMessage = "The variable 'declaredVar2' is assigned but never used."
-$violationName = "PSUseDeclaredVarsMoreThanAssigments"
+$violationName = "PSUseDeclaredVarsMoreThanAssignments"
 $directory = Split-Path -Parent $MyInvocation.MyCommand.Path
 $violations = Invoke-ScriptAnalyzer $directory\UseDeclaredVarsMoreThanAssignments.ps1 | Where-Object {$_.RuleName -eq $violationName}
 $noViolations = Invoke-ScriptAnalyzer $directory\UseDeclaredVarsMoreThanAssignmentsNoViolations.ps1 | Where-Object {$_.RuleName -eq $violationName}