Skip to content

Commit ba7884b

Browse files
committed
nested unit tests
1 parent ef36fdf commit ba7884b

File tree

1 file changed

+17
-15
lines changed

1 file changed

+17
-15
lines changed

src/tools/tests/storage-key-recipe-resolver-test.ts

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ import {assert} from '../../platform/chai-node.js';
1313
import {StorageKeyRecipeResolver} from '../storage-key-recipe-resolver.js';
1414

1515
describe('recipe2plan', () => {
16-
it('Long + Long: If ReadingRecipe is long running, it is a valid use case', async () => {
17-
const manifest = await Manifest.parse(`\
16+
describe('storage-key-recipe-resolver', () => {
17+
it('Long + Long: If ReadingRecipe is long running, it is a valid use case', async () => {
18+
const manifest = await Manifest.parse(`\
1819
particle Reader
1920
data: reads Thing {name: Text}
2021
@@ -41,18 +42,19 @@ describe('recipe2plan', () => {
4142
Reader
4243
data: reads data`);
4344

44-
const resolver = new StorageKeyRecipeResolver(manifest);
45-
for (const it of (await resolver.resolve())) {
46-
assert.isTrue(it.isResolved());
47-
}
45+
const resolver = new StorageKeyRecipeResolver(manifest);
46+
for (const it of (await resolver.resolve())) {
47+
assert.isTrue(it.isResolved());
48+
}
49+
});
50+
// TODO(alxr): Flush out outlined unit tests
51+
it.skip('Short + Short: If WritingRecipe is short lived, it is not valid', () => {});
52+
it.skip('Short + Long: If WritingRecipe is short lived and Reading is long lived, it is not valid', () => {});
53+
it.skip('Invalid Type: If Reader reads {name: Text, age: Number} it is not valid', () => {});
54+
it.skip('No arc id: If arcId of WritingRecipe is not there, it is not valid', () => {});
55+
it.skip('No handleId: If id of handle in WritingRecipe is not provided, it is not valid', () => {});
56+
it.skip('Ambiguous handle: If there are 2 WritingRecipes creating the same handle, it is not valid', () => {});
57+
it.skip('Ambiguous handle + tag disambiguation: If there are 2 WritingRecipes creating the same handle but with different tags and mapping uses one of the tags, it is valid', () => {});
58+
it.skip('No Handle: If there is no writing handle, it is not valid', () => {});
4859
});
49-
// TODO(alxr): Flush out outlined unit tests
50-
it.skip('Short + Short: If WritingRecipe is short lived, it is not valid', () => {});
51-
it.skip('Short + Long: If WritingRecipe is short lived and Reading is long lived, it is not valid', () => {});
52-
it.skip('Invalid Type: If Reader reads {name: Text, age: Number} it is not valid', () => {});
53-
it.skip('No arc id: If arcId of WritingRecipe is not there, it is not valid', () => {});
54-
it.skip('No handleId: If id of handle in WritingRecipe is not provided, it is not valid', () => {});
55-
it.skip('Ambiguous handle: If there are 2 WritingRecipes creating the same handle, it is not valid', () => {});
56-
it.skip('Ambiguous handle + tag disambiguation: If there are 2 WritingRecipes creating the same handle but with different tags and mapping uses one of the tags, it is valid', () => {});
57-
it.skip('No Handle: If there is no writing handle, it is not valid', () => {});
5860
});

0 commit comments

Comments
 (0)