Skip to content

Commit 4806b2b

Browse files
committed
Fix password encoder injection
1 parent af715c5 commit 4806b2b

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/main/java/ru/loolzaaa/authserver/config/security/BasicSecurityConfig.java

+6-3
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,12 @@ public class BasicSecurityConfig {
3030

3131
private final BasicUsersProperties basicUsersProperties;
3232

33+
@Qualifier("basicPasswordEncoder")
34+
private final PasswordEncoder passwordEncoder;
35+
3336
@Bean
3437
@Qualifier("basicUserDetailsService")
35-
public InMemoryUserDetailsManager inMemoryUserDetailsManager(PasswordEncoder passwordEncoder) {
38+
public InMemoryUserDetailsManager inMemoryUserDetailsManager() {
3639
if (basicUsersProperties.getUsers().isEmpty()) {
3740
log.warn("\n\n\tThere is no basic users in properties. Some API unavailable!\n");
3841
}
@@ -56,11 +59,11 @@ public InMemoryUserDetailsManager inMemoryUserDetailsManager(PasswordEncoder pas
5659

5760
@Order(1)
5861
@Bean
59-
public SecurityFilterChain basicFilterChain(HttpSecurity http, PasswordEncoder passwordEncoder) throws Exception {
62+
public SecurityFilterChain basicFilterChain(HttpSecurity http) throws Exception {
6063
final String basicMvcMatcherPattern = "/api/fast/**";
6164
final String basicPrepareLogoutMatcherPattern = "/api/fast/prepare_logout";
6265
http
63-
.userDetailsService(inMemoryUserDetailsManager(passwordEncoder))
66+
.userDetailsService(inMemoryUserDetailsManager())
6467
.antMatcher(basicMvcMatcherPattern)
6568
.csrf().disable()
6669
.sessionManagement(session -> session

src/main/java/ru/loolzaaa/authserver/config/security/SecurityConfig.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ PasswordEncoder jwtPasswordEncoder() {
4444
return new CustomPBKDF2PasswordEncoder();
4545
}
4646

47-
@Profile("!noop")
4847
@Primary
4948
@Qualifier("basicPasswordEncoder")
5049
@Bean
@@ -53,6 +52,7 @@ PasswordEncoder basicPasswordEncoder() {
5352
}
5453

5554
@Profile("noop")
55+
@Qualifier("jwtPasswordEncoder")
5656
@Bean
5757
PasswordEncoder noopPasswordEncoder() {
5858
return new NoopCustomPasswordEncoder();

0 commit comments

Comments
 (0)