Fixed duplicate initialization - fxes #45 #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about initial values? Is that being resolved with this PR? |
nicklasb
added a commit
that referenced
this pull request
Sep 17, 2015
Fixed duplicate initialization - fixes #45
|
They were, adding. |
|
I am using the newest versions (as far as I can tell) and getting two calls for every instance using the options.httpGet || asyncCallback methods. factory.js form.type = 'strapselect';
form.placeholder = 'Select Something';
form.options = {
httpGet: {
"url" : "http://localhost:8080/" + form.url
}
};
return result.form.push(form);controller.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent duplicate calls to asyncCallback (#45), I removed the ng-init from the inner form-group, leaving only the populateTitleMap-call on ui-select-choices, because this call is mad with searchTerm as an empty string, instead of undefined. I figured this is where the ui-select is ready.
I think one populateTitleMap is needed...