Fix objc_autoreleaseReturnValue crash issue

Kyle-Ye · Kyle-Ye · commit e7c0b7a77bfa · 2024-10-29T00:54:19.000+08:00
diff --git a/Sources/OpenSwiftUI_SPI/Overlay/CoreGraphics/OpenSwiftUICoreColor.m b/Sources/OpenSwiftUI_SPI/Overlay/CoreGraphics/OpenSwiftUICoreColor.m
@@ -62,12 +62,11 @@ BOOL OpenSwiftUICoreColorPlatformColorGetComponents(BOOL system, id color, CGFlo
 }
 
 Class _Nullable OpenSwiftUICoreColorGetKitColorClass(BOOL system) {
-    OpenSwiftUICoreColorClass(system);
+    return OpenSwiftUICoreColorClass(system);
 }
 
 Class _Nullable OpenSwiftUICoreColorClass(BOOL system) {
     static BOOL isValid = true;
-    // FIXME: objc_autoreleaseReturnValue will crash
     static Class colorClass;
     static dispatch_once_t once;
     dispatch_once(&once, ^{
diff --git a/Tests/OpenSwiftUI_SPITests/Overlay/CoreGraphics/OpenSwiftUICoreColorTests.swift b/Tests/OpenSwiftUI_SPITests/Overlay/CoreGraphics/OpenSwiftUICoreColorTests.swift
@@ -98,8 +98,7 @@ struct OpenSwiftUICoreColorTests {
     
     @Test
     func getKitColorClass() {
-        let colorClass = OpenSwiftUICoreColorGetKitColorClass(isAppKitBased())
-        print(colorClass)
+        let colorClass: AnyClass? = OpenSwiftUICoreColorGetKitColorClass(isAppKitBased())
         #if os(macOS)
         #expect(colorClass == NSColor.self)
         #elseif os(iOS)

Original file line number	Diff line number	Diff line change
`@@ -62,12 +62,11 @@ BOOL OpenSwiftUICoreColorPlatformColorGetComponents(BOOL system, id color, CGFlo`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`Class _Nullable OpenSwiftUICoreColorGetKitColorClass(BOOL system) {`
`65`		`- OpenSwiftUICoreColorClass(system);`
	`65`	`+ return OpenSwiftUICoreColorClass(system);`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`Class _Nullable OpenSwiftUICoreColorClass(BOOL system) {`
`69`	`69`	`static BOOL isValid = true;`
`70`		`- // FIXME: objc_autoreleaseReturnValue will crash`
`71`	`70`	`static Class colorClass;`
`72`	`71`	`static dispatch_once_t once;`
`73`	`72`	`dispatch_once(&once, ^{`