Skip to content

Commit be76abe

Browse files
committed
Add GraphShims target dependency
1 parent dc8e9ce commit be76abe

File tree

8 files changed

+29
-53
lines changed

8 files changed

+29
-53
lines changed

Package.resolved

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Package.swift

Lines changed: 22 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ let openSwiftUITarget = Target.target(
1414
"OpenSwiftUIShims",
1515
"CoreServices",
1616
"UIKitCore",
17+
.product(name: "OpenGraphShims", package: "OpenGraph"),
1718
],
1819
swiftSettings: [
1920
.enableExperimentalFeature("AccessLevelOnImport"),
@@ -95,25 +96,30 @@ func envEnable(_ key: String, default defaultValue: Bool = false) -> Bool {
9596
}
9697

9798
#if os(macOS)
98-
let attributeGraphCondition = envEnable("OPENSWIFTUI_ATTRIBUTEGRAPH", default: true)
99+
let attributeGraphCondition = envEnable("OPENGRAPH_ATTRIBUTEGRAPH", default: true)
99100
#else
100-
let attributeGraphCondition = envEnable("OPENSWIFTUI_ATTRIBUTEGRAPH")
101+
let attributeGraphCondition = envEnable("OPENGRAPH_ATTRIBUTEGRAPH")
101102
#endif
103+
104+
extension Target {
105+
func addAGSettings() {
106+
dependencies.append(.product(name: "AttributeGraph", package: "OpenGraph"))
107+
108+
var swiftSettings = swiftSettings ?? []
109+
swiftSettings.append(.define("OPENGRAPH_ATTRIBUTEGRAPH"))
110+
self.swiftSettings = swiftSettings
111+
112+
var linkerSettings = linkerSettings ?? []
113+
linkerSettings.append(.unsafeFlags([systemFrameworkSearchFlag, "/System/Library/PrivateFrameworks/"], .when(platforms: [.macOS])))
114+
linkerSettings.append(.linkedFramework("AttributeGraph", .when(platforms: [.macOS])))
115+
self.linkerSettings = linkerSettings
116+
}
117+
}
118+
102119
if attributeGraphCondition {
103-
openSwiftUITarget.dependencies.append(
104-
.product(name: "AttributeGraph", package: "OpenGraph")
105-
)
106-
var swiftSettings = openSwiftUITarget.swiftSettings ?? []
107-
swiftSettings.append(.define("OPENSWIFTUI_ATTRIBUTEGRAPH"))
108-
openSwiftUITarget.swiftSettings = swiftSettings
109-
var linkerSettings = openSwiftUITarget.linkerSettings ?? []
110-
linkerSettings.append(.unsafeFlags([systemFrameworkSearchFlag, "/System/Library/PrivateFrameworks/"], .when(platforms: [.macOS])))
111-
linkerSettings.append(.linkedFramework("AttributeGraph", .when(platforms: [.macOS])))
112-
openSwiftUITarget.linkerSettings = linkerSettings
113-
} else {
114-
openSwiftUITarget.dependencies.append(
115-
.product(name: "OpenGraph", package: "OpenGraph")
116-
)
120+
openSwiftUITarget.addAGSettings()
121+
openSwiftUITestTarget.addAGSettings()
122+
openSwiftUICompatibilityTestTarget.addAGSettings()
117123
}
118124

119125
#if os(macOS)

Sources/OpenSwiftUI/DataAndStorage/Internal/Property/PropertyList.swift

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,7 @@
77
// Status: Blocked by merge
88
// ID: 2B32D570B0B3D2A55DA9D4BFC1584D20
99

10-
#if OPENSWIFTUI_ATTRIBUTEGRAPH
11-
internal import AttributeGraph
12-
#else
13-
internal import OpenGraph
14-
#endif
10+
internal import OpenGraphShims
1511

1612
// MARK: - PropertyList
1713

Sources/OpenSwiftUI/DataAndStorage/Internal/UniqueID.swift

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@
66
// Lastest Version: iOS 15.5
77
// Status: Complete
88

9-
#if OPENSWIFTUI_ATTRIBUTEGRAPH
10-
internal import AttributeGraph
11-
#else
12-
internal import OpenGraph
13-
#endif
9+
internal import OpenGraphShims
1410

1511
struct UniqueID: Hashable {
1612
static let zero = UniqueID(value: 0)
@@ -19,11 +15,7 @@ struct UniqueID: Hashable {
1915

2016
@inline(__always)
2117
init() {
22-
#if OPENSWIFTUI_ATTRIBUTEGRAPH
23-
self.value = Int(AGMakeUniqueID())
24-
#else
25-
self.value = Int(OGMakeUniqueID())
26-
#endif
18+
value = Int(makeUniqueID())
2719
}
2820

2921
private init(value: Int) {

Sources/OpenSwiftUI/GraphShims.swift

Lines changed: 0 additions & 6 deletions
This file was deleted.

Sources/OpenSwiftUI/Internal/Graph/TODO/_GraphInputs.swift

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
#if OPENSWIFTUI_ATTRIBUTEGRAPH
2-
internal import AttributeGraph
3-
#else
4-
internal import OpenGraph
5-
#endif
1+
internal import OpenGraphShims
62

73
public struct _GraphInputs {
84
// var customInputs: PropertyList

Sources/OpenSwiftUI/Internal/Graph/TODO/_GraphValue.swift

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
#if OPENSWIFTUI_ATTRIBUTEGRAPH
2-
internal import AttributeGraph
3-
#else
4-
internal import OpenGraph
5-
#endif
1+
internal import OpenGraphShims
62

73
public struct _GraphValue<Value>: Equatable {
84
var value: Attribute<Value>

Sources/OpenSwiftUI/Views/View/TODO/_ConditionalContent.swift

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,7 @@
88
// Status: WIP
99
// ID: 1A625ACC143FD8524C590782FD8F4F8C
1010

11-
#if OPENSWIFTUI_ATTRIBUTEGRAPH
12-
internal import AttributeGraph
13-
#else
14-
internal import OpenGraph
15-
#endif
11+
internal import OpenGraphShims
1612

1713
@frozen
1814
public struct _ConditionalContent<TrueContent, FalseContent> {

0 commit comments

Comments
 (0)