Update ViewList (#103)

* Add makeViewList implementation

* Complete missing EmptyView implementation

* Update ViewTraitKeys

* Fix AnyViewChildList implementation

* Add some doc for Model

* Update MutableBox implementation

* Update AnyViewList

* Update ViewList

* Fix compile issue

* Fix werror issue

Author: Kyle-Ye

Package.resolved

@@ -1,13 +1,13 @@
 {
-  "originHash" : "7c61cf2fa8336371c9cc17d001d4e08e34b0f8b92c637a0c44f1b2cd08cd55b2",
+  "originHash" : "9749b5257cf4f28f086bdeac0424718c7ae499aeea22fdc45686fac00d8d561d",
   "pins" : [
     {
       "identity" : "opengraph",
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/OpenSwiftUIProject/OpenGraph",
       "state" : {
         "branch" : "main",
-        "revision" : "48ad5323175fbfdfde2287bbf26c3e5a861ae2bb"
+        "revision" : "58961e8c7fb7528a89dcd77a3a28a950f1791f1f"
       }
     },
     {

Sources/OpenSwiftUI/Core/Data/Boxes/MutableBox.swift

@@ -2,33 +2,38 @@
 //  MutableBox.swift
 //  OpenSwiftUI
 //
-//  Audited for RELEASE_2021
+//  Audited for RELEASE_2024
 //  Status: Complete
 
 @propertyWrapper
-final class MutableBox<A> {
-    private var value: A
-
-    var wrappedValue: A {
-        get { value }
-        set { value = newValue }
-    }
+final package class MutableBox<T> {
+    final package var value: T
 
-    init(_ value: A) {
+    @inlinable
+    package init(_ value: T) {
         self.value = value
     }
 
-    init(wrappedValue value: A) {
-        self.value = value
+    @inlinable
+    convenience package init(wrappedValue value: T) {
+        self.init(value)
     }
-
-    var projectedValue: MutableBox<A> {
+    
+    @inlinable
+    final package var wrappedValue: T {
+        get { value }
+        set { value = newValue }
+    }
+    
+    @inlinable
+    final package var projectedValue: MutableBox<T> {
         self
     }
 }
 
-extension MutableBox: Equatable where A: Equatable {
-    static func == (lhs: MutableBox<A>, rhs: MutableBox<A>) -> Bool {
+extension MutableBox: Equatable where T: Equatable {
+    @inlinable
+    package static func == (lhs: MutableBox<T>, rhs: MutableBox<T>) -> Bool {
         lhs.value == rhs.value
     }
 }

Sources/OpenSwiftUI/Core/Data/Location/AnyLocation.swift

@@ -5,11 +5,18 @@
 //  Audited for RELEASE_2021
 //  Status: Complete
 
+/// The base type of all type-erased locations.
 @usableFromInline
 class AnyLocationBase {}
 
+/// The base type of all type-erased locations with value-type Value.
+/// It is annotated as `@unchecked Sendable` so that user types such as
+/// `State`, and `SceneStorage` can be cleanly `Sendable`. However, it is
+/// also the user types' responsibility to ensure that `get`, and `set` does
+/// not access the graph concurrently (`get` should not be called while graph
+/// is updating, for example).
 @usableFromInline
-class AnyLocation<Value>: AnyLocationBase {
+class AnyLocation<Value>: AnyLocationBase, @unchecked Sendable {
     var wasRead: Bool {
         get { fatalError() }
         set { fatalError() }

Sources/OpenSwiftUI/Core/Data/Property/PropertyList.swift

@@ -11,6 +11,7 @@ internal import OpenGraphShims
 
 // MARK: - PropertyList
 
+/// A mutable container of key-value pairs
 @usableFromInline
 @frozen
 struct PropertyList: CustomStringConvertible {

Sources/OpenSwiftUI/Core/View/CustomView.swift

@@ -15,6 +15,7 @@ extension View {
         let (body, buffer) = inputs.withMutateGraphInputs { inputs in
             makeBody(view: view, inputs: &inputs, fields: fields)
         }
+        // FIXME
         let outputs = _ViewDebug.makeView(
             view: body,
             inputs: inputs
@@ -27,6 +28,19 @@ extension View {
         return outputs
     }
 
+    static func makeViewList(view: _GraphValue<Self>, inputs: _ViewListInputs) -> _ViewListOutputs {
+        let fields = DynamicPropertyCache.fields(of: Self.self)
+        var inputs = inputs
+        let (body, buffer) = inputs.withMutateGraphInputs { inputs in
+            makeBody(view: view, inputs: &inputs, fields: fields)
+        }
+        let outputs = Body.makeDebuggableViewList(view: body, inputs: inputs)
+        if let buffer {
+            buffer.traceMountedProperties(to: body, fields: fields)
+        }
+        return outputs
+    }
+    
     private static func makeBody(
         view: _GraphValue<Self>,
         inputs: inout _GraphInputs,

Sources/OpenSwiftUI/Core/View/VariadicView/VariadicView_ImplicitRoot.swift

@@ -18,7 +18,7 @@ package protocol _VariadicView_ImplicitRoot: _VariadicView_AnyImplicitRoot, _Var
 }
 
 extension _VariadicView_ImplicitRoot {
-    package func visitType<Visitor: _VariadicView_ImplicitRootVisitor>(visitor: inout Visitor) {
+    package static func visitType<V>(visitor: inout V) where V: _VariadicView_ImplicitRootVisitor {
         visitor.visit(type: Self.self)
     }
 }

Sources/OpenSwiftUI/Core/View/View.swift

@@ -85,7 +85,7 @@ extension View {
     }
 
     public static func _makeViewList(view: _GraphValue<Self>, inputs: _ViewListInputs) -> _ViewListOutputs {
-        fatalError("TODO")
+        makeViewList(view: view, inputs: inputs)
     }
 
     public static func _viewListCount(inputs: _ViewListCountInputs) -> Int? {