From d25ba154809113b2a1accaa16c7791299477737c Mon Sep 17 00:00:00 2001 From: Andy Jordan Date: Wed, 5 Oct 2022 10:48:32 -0700 Subject: [PATCH 1/3] Remove duplicate `JetBrains.ReSharper.CommandLineTools` package reference This line was a duplicate and the build tools complained about it. --- .build/.build.csproj | 1 - 1 file changed, 1 deletion(-) diff --git a/.build/.build.csproj b/.build/.build.csproj index 7233e8972..509faac59 100644 --- a/.build/.build.csproj +++ b/.build/.build.csproj @@ -14,7 +14,6 @@ - From 20ed43b92553f7e72ccb33a7d387d202870aaf5f Mon Sep 17 00:00:00 2001 From: Andy Jordan Date: Wed, 5 Oct 2022 10:49:21 -0700 Subject: [PATCH 2/3] Bump SampleServer's `Microsoft.Extensions.Logging` package In order to allow it to restore since this dependency was updated upstream, and that was causing it to fail to restore due to the detected forced downgrade. --- sample/SampleServer/SampleServer.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sample/SampleServer/SampleServer.csproj b/sample/SampleServer/SampleServer.csproj index f793325cd..c53281cd5 100644 --- a/sample/SampleServer/SampleServer.csproj +++ b/sample/SampleServer/SampleServer.csproj @@ -10,7 +10,7 @@ - + From 6c695e3606404ab0a0caefac49397e8e7b84a70d Mon Sep 17 00:00:00 2001 From: Andy Jordan Date: Wed, 5 Oct 2022 10:20:37 -0700 Subject: [PATCH 3/3] Fix bug caused by `System.Threading.Tasks` v4.7.1 Unfortunately `System.Threading.Tasks` v4.7.1 is broken. Its package manifest states that it depends on `System.Threading.Tasks.Extensions` >= v4.5.4 (assembly version v4.2.0.1); however, for some reason it actually requests v4.2.0.0. While neither OmniSharp nor PowerShell Editor Services, the downstream library where this bug appeared, ship that version of the library, it can sometimes be found in the Global Assembly Cache on Windows. When present (due to an installation by some other program), it gets loaded, and then other dependencies (correctly) request v4.2.0.1 which also gets loaded. When both are loaded, a `System.MissingMethodException` is thrown! Specifically the method `ChannelReader.ReadAsync` (from `System.Threading.Tasks`) on the type `Tasks.ValueTask` (provided by `System.Threading.Tasks.Extensions`) can no longer be resolved. I do not know enough about the intricacies of method/type resolution in the full .NET Framework as to explain precisely why the presence of v4.2.0.0 causes this resolution to fail, but it certainly does. Upgrading `System.Threading.Tasks` to v6.0.0 is confirmed to solve the problem, since the newer package correctly requests `System.Threading.Tasks.Extensions` v4.2.0.1. --- Directory.Packages.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Directory.Packages.props b/Directory.Packages.props index 8562ba115..6916daa35 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -49,7 +49,7 @@ - +