Skip to content

FilePaths with foreign characters can't be used for LSP events to the server #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NTaylorMullen opened this issue Mar 21, 2019 · 4 comments

Comments

@NTaylorMullen
Copy link

See https://github.com/aspnet/Razor.VSCode/issues/252.

Dan mentioned it might be due to:

Is the issue here possibly that we need to enable IRI support in System.Uri?:

https://docs.microsoft.com/en-us/dotnet/framework/network-programming/international-resource-identifier-support-in-system-uri

Daniel Roth
@david-driscoll
Copy link
Member

@NTaylorMullen I tried adding a test and things appear to work on my end, I wonder if vscode is somehow mangling the uri?

See: #130

@NTaylorMullen
Copy link
Author

I wonder if vscode is somehow mangling the uri?

Hmmm, maybe? That being said I'd imagine there would be a whole lot more issues if they weren't following the spec for the LSP URI.

@NTaylorMullen
Copy link
Author

Maybe it's the cross-plat URI impl? One user in VSCode's path was: /home/tiago/Área de Trabalho/projeto/ONE/SOURCE/Site/Views/Cadastro/Parametro/Usuario/Index.cshtml

@NTaylorMullen
Copy link
Author

This looked to be due to the version of .NET Core I was using. Upgrading to netcoreapp2.2 in my app fixed the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants