Skip to content

Commit dbd1178

Browse files
JoeRobichJoeRobich
authored
Merge pull request #1019 from JoeRobich/update-3.17
Update with the 3.17 spec changes
2 parents bed3f73 + 808d6be commit dbd1178

File tree

321 files changed

+15386
-4117
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

321 files changed

+15386
-4117
lines changed

‎.build/.build.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
</PropertyGroup>
1212

1313
<ItemGroup>
14-
<PackageReference Include="JetBrains.ReSharper.CommandLineTools" ExcludeAssets="All" />
1514
<PackageReference Include="GitVersion.Tool" ExcludeAssets="All" />
1615
<PackageReference Include="ReportGenerator" ExcludeAssets="All" />
1716
<PackageReference Include="Rocket.Surgery.Nuke" />

‎.github/workflows/ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ jobs:
7979
runs-on: ${{ matrix.os }}
8080
steps:
8181
- name: Checkout
82-
uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
82+
uses: actions/[email protected]
8383
with:
8484
clean: 'false'
8585
fetch-depth: '0'
@@ -117,7 +117,7 @@ jobs:
117117
run: |
118118
dotnet nuke Pack --skip
119119
- name: 🐿 Publish Coverage
120-
uses: codecov/codecov-action@v4
120+
uses: codecov/codecov-action@v4.0.0-beta.2
121121
with:
122122
name: 'actions-${{ matrix.os }}'
123123
- name: 🏺 Publish logs

‎.github/workflows/close-milestone.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
runs-on: ubuntu-latest
1111
steps:
1212
- name: Checkout
13-
uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
13+
uses: actions/[email protected]
1414
with:
1515
fetch-depth: 0
1616

‎.github/workflows/draft-release.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
runs-on: ubuntu-latest
1515
steps:
1616
- name: Checkout
17-
uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
17+
uses: actions/[email protected]
1818
with:
1919
fetch-depth: 0
2020

‎.github/workflows/sync-labels.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
runs-on: ubuntu-latest
1717
steps:
1818
- name: Checkout
19-
uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
19+
uses: actions/[email protected]
2020

2121
- name: Run Labeler
2222
if: success()

‎.github/workflows/update-milestone.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
runs-on: ubuntu-latest
1414
steps:
1515
- name: Checkout
16-
uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
16+
uses: actions/[email protected]
1717
with:
1818
ref: ${{ github.sha }}
1919
fetch-depth: 0

‎.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,4 @@ coverage.info
4646
/codealike.json
4747
.tmp/
4848
.nuke/temp/
49+
**/*.received.cs

‎.nuke/build.schema.json

+1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
"AppVeyor",
3838
"AzurePipelines",
3939
"Bamboo",
40+
"Bitbucket",
4041
"Bitrise",
4142
"GitHubActions",
4243
"GitLab",

‎Directory.Packages.props

+3-1
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,13 @@
3535
<PackageVersion Include="Microsoft.Extensions.Options" Version="6.0.0" />
3636
<PackageVersion Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="6.0.0" />
3737
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="6.0.0" />
38-
<PackageVersion Include="Newtonsoft.Json" Version="11.0.2" />
38+
<PackageVersion Include="Newtonsoft.Json" Version="13.0.1" />
3939
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />
4040
<PackageVersion Include="xunit.runner.visualstudio" Version="2.4.5" />
4141
<PackageVersion Include="xunit" Version="2.4.2" />
4242
<PackageVersion Include="FluentAssertions" Version="6.12.0" />
43+
<PackageVersion Include="Verify.Xunit" Version="16.8.1" />
44+
<PackageVersion Include="Verify.SourceGenerators" Version="1.5.0-beta.1" />
4345
<PackageVersion Include="NSubstitute" Version="5.1.0" />
4446
<PackageVersion Include="Serilog.Extensions.Logging" Version="3.1.0" />
4547
<PackageVersion Include="Serilog.Sinks.Observable" Version="2.0.2" />

‎LSP.sln

+69-3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{D764E024-3D3
66
ProjectSection(SolutionItems) = preProject
77
src\Directory.Build.props = src\Directory.Build.props
88
src\Directory.Build.targets = src\Directory.Build.targets
9+
src\.editorconfig = src\.editorconfig
910
EndProjectSection
1011
EndProject
1112
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "test", "test", "{2F323ED5-EBF8-45E1-B9D3-C014561B3DDA}"
@@ -38,6 +39,8 @@ EndProject
3839
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SampleServer", "sample\SampleServer\SampleServer.csproj", "{F2067F5F-FA4E-4990-B301-E7898FC4C45F}"
3940
EndProject
4041
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "sample", "sample", "{A316FCEC-81AD-45FB-93EE-C62CA09300DC}"
42+
ProjectSection(SolutionItems) = preProject
43+
EndProjectSection
4144
EndProject
4245
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Client", "src\Client\Client.csproj", "{417E95B2-5AB9-49D5-B7CD-12255472E2E7}"
4346
EndProject
@@ -53,8 +56,6 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Dap.Server", "src\Dap.Serve
5356
EndProject
5457
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = ".build", ".build\.build.csproj", "{28B13787-A442-4D28-BF9A-3D65BF13AAEC}"
5558
EndProject
56-
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".build", ".build", "{26522B49-0743-4CBE-BA67-6D17FF65CAB9}"
57-
EndProject
5859
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Shared", "src\Shared\Shared.csproj", "{18FB2302-023B-4F6F-9F6D-099B47B69D9F}"
5960
EndProject
6061
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Dap.Tests", "test\Dap.Tests\Dap.Tests.csproj", "{6D9E5BF4-4666-476B-AC88-D108A80567F6}"
@@ -81,6 +82,67 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Protocol.Proposals", "src\P
8182
EndProject
8283
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Lsp.Integration.Tests", "test\Lsp.Integration.Tests\Lsp.Integration.Tests.csproj", "{72A74595-A278-46F0-9C8B-3151C9681B91}"
8384
EndProject
85+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "config", "config", "{93A0F406-2CEB-491E-9F40-6DA1BA67DD7C}"
86+
ProjectSection(SolutionItems) = preProject
87+
.config\dotnet-tools.json = .config\dotnet-tools.json
88+
Directory.Build.props = Directory.Build.props
89+
Directory.Packages.props = Directory.Packages.props
90+
Directory.Packages.supports.props = Directory.Packages.supports.props
91+
Directory.Build.targets = Directory.Build.targets
92+
.editorconfig = .editorconfig
93+
build.cmd = build.cmd
94+
build.sh = build.sh
95+
build.ps1 = build.ps1
96+
GitReleaseManager.yaml = GitReleaseManager.yaml
97+
.codecov.yml = .codecov.yml
98+
.azure-pipelines.yml = .azure-pipelines.yml
99+
.appveyor.yml = .appveyor.yml
100+
azure-pipelines.nuke.yml = azure-pipelines.nuke.yml
101+
GitVersion.yml = GitVersion.yml
102+
.travis.yml = .travis.yml
103+
LICENSE = LICENSE
104+
README.md = README.md
105+
.gitignore = .gitignore
106+
.gitattributes = .gitattributes
107+
.prettierignore = .prettierignore
108+
.prettierrc = .prettierrc
109+
.lintstagedrc.js = .lintstagedrc.js
110+
NuGet.config = NuGet.config
111+
package.json = package.json
112+
EndProjectSection
113+
EndProject
114+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".github", ".github", "{19909559-F753-4337-952B-A8B5B5889959}"
115+
ProjectSection(SolutionItems) = preProject
116+
.github\labels.yml = .github\labels.yml
117+
.github\renovate.json = .github\renovate.json
118+
EndProjectSection
119+
EndProject
120+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "workflows", "workflows", "{97924298-E17E-46E6-83CC-D9CD3B9F5E6F}"
121+
ProjectSection(SolutionItems) = preProject
122+
.github\workflows\ci-ignore.yml = .github\workflows\ci-ignore.yml
123+
.github\workflows\draft-release.yml = .github\workflows\draft-release.yml
124+
.github\workflows\publish-nuget.yml = .github\workflows\publish-nuget.yml
125+
.github\workflows\dependabot-merge.yml = .github\workflows\dependabot-merge.yml
126+
.github\workflows\sync-labels.yml = .github\workflows\sync-labels.yml
127+
.github\workflows\close-milestone.yml = .github\workflows\close-milestone.yml
128+
.github\workflows\update-milestone.yml = .github\workflows\update-milestone.yml
129+
.github\workflows\ci.yml = .github\workflows\ci.yml
130+
EndProjectSection
131+
EndProject
132+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".husky", ".husky", "{BED6765C-97D8-406D-B782-3307132D16F0}"
133+
ProjectSection(SolutionItems) = preProject
134+
.husky\pre-commit = .husky\pre-commit
135+
EndProjectSection
136+
EndProject
137+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".vscode", ".vscode", "{09BE8ED9-1986-40F3-A9A6-D826A7413581}"
138+
ProjectSection(SolutionItems) = preProject
139+
.vscode\settings.json = .vscode\settings.json
140+
.vscode\csharp.code-snippets = .vscode\csharp.code-snippets
141+
.vscode\launch.json = .vscode\launch.json
142+
.vscode\tasks.json.old = .vscode\tasks.json.old
143+
.vscode\tasks.json = .vscode\tasks.json
144+
EndProjectSection
145+
EndProject
84146
Global
85147
GlobalSection(SolutionConfigurationPlatforms) = preSolution
86148
Debug|Any CPU = Debug|Any CPU
@@ -388,7 +450,7 @@ Global
388450
{E540868F-438E-4F7F-BBB7-010D6CB18A57} = {D764E024-3D3F-4112-B932-2DB722A1BACC}
389451
{F2C9D555-118E-442B-A953-9A7B58A53F33} = {D764E024-3D3F-4112-B932-2DB722A1BACC}
390452
{E1A9123B-A236-4240-8C82-A61BD85C3BF4} = {D764E024-3D3F-4112-B932-2DB722A1BACC}
391-
{28B13787-A442-4D28-BF9A-3D65BF13AAEC} = {26522B49-0743-4CBE-BA67-6D17FF65CAB9}
453+
{28B13787-A442-4D28-BF9A-3D65BF13AAEC} = {93A0F406-2CEB-491E-9F40-6DA1BA67DD7C}
392454
{18FB2302-023B-4F6F-9F6D-099B47B69D9F} = {D764E024-3D3F-4112-B932-2DB722A1BACC}
393455
{6D9E5BF4-4666-476B-AC88-D108A80567F6} = {2F323ED5-EBF8-45E1-B9D3-C014561B3DDA}
394456
{678A4DD2-A656-4DCC-AE78-F9940C82A6E6} = {D764E024-3D3F-4112-B932-2DB722A1BACC}
@@ -402,6 +464,10 @@ Global
402464
{D43637CC-94E6-4ED4-BAA3-E5D1AD3285F5} = {D764E024-3D3F-4112-B932-2DB722A1BACC}
403465
{201B1CA7-AB12-41AD-9246-BC30F2EBE2DF} = {D764E024-3D3F-4112-B932-2DB722A1BACC}
404466
{72A74595-A278-46F0-9C8B-3151C9681B91} = {2F323ED5-EBF8-45E1-B9D3-C014561B3DDA}
467+
{19909559-F753-4337-952B-A8B5B5889959} = {93A0F406-2CEB-491E-9F40-6DA1BA67DD7C}
468+
{97924298-E17E-46E6-83CC-D9CD3B9F5E6F} = {19909559-F753-4337-952B-A8B5B5889959}
469+
{BED6765C-97D8-406D-B782-3307132D16F0} = {93A0F406-2CEB-491E-9F40-6DA1BA67DD7C}
470+
{09BE8ED9-1986-40F3-A9A6-D826A7413581} = {93A0F406-2CEB-491E-9F40-6DA1BA67DD7C}
405471
EndGlobalSection
406472
GlobalSection(ExtensibilityGlobals) = postSolution
407473
SolutionGuid = {D38DD0EC-D095-4BCD-B8AF-2D788AF3B9AE}

‎global.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
"version": "6.0.414",
44
"rollForward": "latestMinor"
55
}
6-
}
6+
}

‎language-server-protocol.sha.txt

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
-- This is the last commit we caught up with https://github.com/Microsoft/language-server-protocol/commits/gh-pages
2-
lastSha: bdcc0f2
2+
lastSha: 5fc92456c046ed980646bb95c1d2e390d5b3ef9d
3+
4+
https://github.com/Microsoft/language-server-protocol/compare/5fc92456c046ed980646bb95c1d2e390d5b3ef9d..gh-pages
35

4-
https://github.com/Microsoft/language-server-protocol/compare/bdcc0f2..gh-pages

‎sample/SampleServer/FoldingRangeHandler.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ internal class FoldingRangeHandler : IFoldingRangeHandler
1010
{
1111
public FoldingRangeRegistrationOptions GetRegistrationOptions() =>
1212
new FoldingRangeRegistrationOptions {
13-
DocumentSelector = DocumentSelector.ForLanguage("csharp")
13+
DocumentSelector = TextDocumentSelector.ForLanguage("csharp")
1414
};
1515

1616
public Task<Container<FoldingRange>?> Handle(
@@ -30,7 +30,7 @@ CancellationToken cancellationToken
3030
);
3131

3232
public FoldingRangeRegistrationOptions GetRegistrationOptions(FoldingRangeCapability capability, ClientCapabilities clientCapabilities) => new FoldingRangeRegistrationOptions {
33-
DocumentSelector = DocumentSelector.ForLanguage("csharp")
33+
DocumentSelector = TextDocumentSelector.ForLanguage("csharp")
3434
};
3535
}
3636
}

‎sample/SampleServer/SampleServer.csproj

+4-10
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,10 @@
1010

1111
<ItemGroup>
1212
<ProjectReference Include="../../src/Server/Server.csproj" />
13-
<PackageReference Include="Microsoft.Extensions.Logging" VersionOverride="6.0.0" />
14-
<PackageReference Include="Serilog.Extensions.Logging" VersionOverride="3.1.0" />
15-
<PackageReference Include="Serilog.Sinks.File" VersionOverride="5.0.0" />
16-
<PackageReference Include="Serilog.Sinks.Debug" VersionOverride="2.0.0" />
17-
<PackageReference Include="System.IO.FileSystem.Primitives" VersionOverride="4.3.0" />
18-
<PackageReference Include="System.IO" VersionOverride="4.3.0" />
19-
<PackageReference Include="System.Runtime.Handles" VersionOverride="4.3.0" />
20-
<PackageReference Include="System.Text.Encoding" VersionOverride="4.3.0" />
21-
<PackageReference Include="System.Text.Encoding.Extensions" VersionOverride="4.3.0" />
22-
<PackageReference Include="System.Threading.Tasks" VersionOverride="4.3.0" />
13+
<PackageReference Include="Microsoft.Extensions.Logging" />
14+
<PackageReference Include="Serilog.Extensions.Logging" />
15+
<PackageReference Include="Serilog.Sinks.File" />
16+
<PackageReference Include="Serilog.Sinks.Debug" />
2317
<PackageReference Include="Nerdbank.Streams" />
2418
</ItemGroup>
2519

‎sample/SampleServer/SemanticTokensHandler.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ protected override SemanticTokensRegistrationOptions CreateRegistrationOptions(
9595
{
9696
return new SemanticTokensRegistrationOptions
9797
{
98-
DocumentSelector = DocumentSelector.ForLanguage("csharp"),
98+
DocumentSelector = TextDocumentSelector.ForLanguage("csharp"),
9999
Legend = new SemanticTokensLegend
100100
{
101101
TokenModifiers = capability.TokenModifiers,

‎sample/SampleServer/TextDocumentHandler.cs

+9-11
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ internal class TextDocumentHandler : TextDocumentSyncHandlerBase
2525
private readonly ILogger<TextDocumentHandler> _logger;
2626
private readonly ILanguageServerConfiguration _configuration;
2727

28-
private readonly DocumentSelector _documentSelector = new DocumentSelector(
29-
new DocumentFilter {
28+
private readonly TextDocumentSelector _textDocumentSelector = new TextDocumentSelector(
29+
new TextDocumentFilter {
3030
Pattern = "**/*.cs"
3131
}
3232
);
@@ -69,8 +69,8 @@ public override Task<Unit> Handle(DidCloseTextDocumentParams notification, Cance
6969

7070
public override Task<Unit> Handle(DidSaveTextDocumentParams notification, CancellationToken token) => Unit.Task;
7171

72-
protected override TextDocumentSyncRegistrationOptions CreateRegistrationOptions(SynchronizationCapability capability, ClientCapabilities clientCapabilities) => new TextDocumentSyncRegistrationOptions() {
73-
DocumentSelector = _documentSelector,
72+
protected override TextDocumentSyncRegistrationOptions CreateRegistrationOptions(TextSynchronizationCapability capability, ClientCapabilities clientCapabilities) => new TextDocumentSyncRegistrationOptions() {
73+
DocumentSelector = _textDocumentSelector,
7474
Change = Change,
7575
Save = new SaveOptions() { IncludeText = true }
7676
};
@@ -129,7 +129,7 @@ CancellationToken cancellationToken
129129
}
130130

131131
public DocumentSymbolRegistrationOptions GetRegistrationOptions(DocumentSymbolCapability capability, ClientCapabilities clientCapabilities) => new DocumentSymbolRegistrationOptions {
132-
DocumentSelector = DocumentSelector.ForLanguage("csharp")
132+
DocumentSelector = TextDocumentSelector.ForLanguage("csharp")
133133
};
134134
}
135135

@@ -146,7 +146,7 @@ public MyWorkspaceSymbolsHandler(IServerWorkDoneManager serverWorkDoneManager, I
146146
_logger = logger;
147147
}
148148

149-
public async Task<Container<SymbolInformation>> Handle(
149+
public async Task<Container<WorkspaceSymbol>> Handle(
150150
WorkspaceSymbolParams request,
151151
CancellationToken cancellationToken
152152
)
@@ -190,9 +190,8 @@ CancellationToken cancellationToken
190190

191191
partialResults.OnNext(
192192
new[] {
193-
new SymbolInformation {
193+
new WorkspaceSymbol {
194194
ContainerName = "Partial Container",
195-
Deprecated = true,
196195
Kind = SymbolKind.Constant,
197196
Location = new Location {
198197
Range = new Range(
@@ -221,15 +220,14 @@ CancellationToken cancellationToken
221220
);
222221

223222
partialResults.OnCompleted();
224-
return new SymbolInformation[] { };
223+
return new WorkspaceSymbol[] { };
225224
}
226225

227226
try
228227
{
229228
return new[] {
230-
new SymbolInformation {
229+
new WorkspaceSymbol {
231230
ContainerName = "Container",
232-
Deprecated = true,
233231
Kind = SymbolKind.Constant,
234232
Location = new Location {
235233
Range = new Range(

‎src/Client/DefaultLanguageClientFacade.cs

+4
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ namespace OmniSharp.Extensions.LanguageServer.Client
1313
internal class DefaultLanguageClientFacade : LanguageProtocolProxy, ILanguageClientFacade, IOnLanguageClientStarted
1414
{
1515
private readonly Lazy<ITextDocumentLanguageClient> _textDocument;
16+
private readonly Lazy<INotebookDocumentLanguageClient> _notebookDocument;
1617
private readonly Lazy<IClientLanguageClient> _client;
1718
private readonly Lazy<IGeneralLanguageClient> _general;
1819
private readonly Lazy<IWindowLanguageClient> _window;
@@ -28,6 +29,7 @@ public DefaultLanguageClientFacade(
2829
IProgressManager progressManager,
2930
ILanguageProtocolSettings languageProtocolSettings,
3031
Lazy<ITextDocumentLanguageClient> textDocument,
32+
Lazy<INotebookDocumentLanguageClient> notebookDocument,
3133
Lazy<IClientLanguageClient> client,
3234
Lazy<IGeneralLanguageClient> general,
3335
Lazy<IWindowLanguageClient> window,
@@ -38,6 +40,7 @@ IInsanceHasStarted instanceHasStarted
3840
) : base(requestRouter, resolverContext, progressManager, languageProtocolSettings)
3941
{
4042
_textDocument = textDocument;
43+
_notebookDocument = notebookDocument;
4144
_client = client;
4245
_general = general;
4346
_window = window;
@@ -48,6 +51,7 @@ IInsanceHasStarted instanceHasStarted
4851
}
4952

5053
public ITextDocumentLanguageClient TextDocument => _textDocument.Value;
54+
public INotebookDocumentLanguageClient NotebookDocument => _notebookDocument.Value;
5155
public IClientLanguageClient Client => _client.Value;
5256
public IGeneralLanguageClient General => _general.Value;
5357
public IWindowLanguageClient Window => _window.Value;

‎src/Client/LanguageClient.cs

+3
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ internal LanguageClient(
177177
IEnumerable<OnLanguageClientStartedDelegate> startedDelegates,
178178
IEnumerable<IOnLanguageClientStarted> startedHandlers,
179179
ITextDocumentLanguageClient textDocumentLanguageClient,
180+
INotebookDocumentLanguageClient notebookDocumentLanguageClient,
180181
IClientLanguageClient clientLanguageClient,
181182
IGeneralLanguageClient generalLanguageClient,
182183
IWindowLanguageClient windowLanguageClient,
@@ -228,13 +229,15 @@ IScheduler scheduler
228229

229230
// We need to at least create Window here in case any handler does loggin in their constructor
230231
TextDocument = textDocumentLanguageClient;
232+
NotebookDocument = notebookDocumentLanguageClient;
231233
Client = clientLanguageClient;
232234
General = generalLanguageClient;
233235
Window = windowLanguageClient;
234236
Workspace = workspaceLanguageClient;
235237
}
236238

237239
public ITextDocumentLanguageClient TextDocument { get; }
240+
public INotebookDocumentLanguageClient NotebookDocument { get; }
238241
public IClientLanguageClient Client { get; }
239242
public IGeneralLanguageClient General { get; }
240243
public IWindowLanguageClient Window { get; }

0 commit comments

Comments
 (0)