Skip to content

Commit 86226b7

Browse files
committed
Remove logging since this code path is essentially untestable.
Reverts part of the original fix from #60 (we can't get this path covered with reasonable effort).
1 parent 39167aa commit 86226b7

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/Server/LspRequestRouter.cs

+2-4
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,9 @@ public async Task<ErrorResponse> RouteRequest(IHandlerDescriptor descriptor, Req
123123
{
124124
@params = request.Params?.ToObject(descriptor.Params, _serializer.JsonSerializer);
125125
}
126-
catch (Exception cannotDeserializeRequestParams)
126+
catch
127127
{
128-
_logger.LogError(new EventId(-32602), cannotDeserializeRequestParams, "Failed to deserialise request parameters.");
129-
130-
return new InvalidParams(request.Id);
128+
return new InvalidParams(request.Id);
131129
}
132130

133131
result = ReflectionRequestHandlers.HandleRequest(descriptor, @params, cts.Token);

0 commit comments

Comments
 (0)