Workaround Unicode characters in URIs .NET bug

Author: TylerLeonhardt

src/Protocol/Serialization/Converters/AbsoluteUriConverter.cs

@@ -51,7 +51,21 @@ public override void WriteJson(JsonWriter writer, Uri value, JsonSerializer seri
                 throw new JsonSerializationException("The URI value must be an absolute Uri. Relative URI instances are not allowed.");
             }
 
-            writer.WriteValue(uriValue.ToString());
+            if (uriValue.IsFile)
+            {
+                // Regular file paths
+                if (uriValue.HostNameType == UriHostNameType.Basic)
+                {
+                    writer.WriteValue($"{uriValue.Scheme}://{uriValue.PathAndQuery}");
+                    return;
+                }
+
+                // UNC file paths
+                writer.WriteValue($"{uriValue.Scheme}://{uriValue.Host}{uriValue.PathAndQuery}");
+                return;
+            }
+
+            writer.WriteValue(uriValue.AbsoluteUri);
         }
     }
 }

test/Lsp.Tests/Models/ApplyWorkspaceEditParamsTests.cs

@@ -43,6 +43,37 @@ public void SimpleTest(string expected)
             deresult.Should().BeEquivalentTo(model);
         }
 
+        [Theory, JsonFixture]
+        public void NonStandardCharactersTest(string expected)
+        {
+            var model = new ApplyWorkspaceEditParams()
+            {
+                Edit = new WorkspaceEdit()
+                {
+                    Changes = new Dictionary<Uri, IEnumerable<TextEdit>>() {
+                        {
+                            new Uri("/abc/123/Mörkö.cs"), new [] {
+                                new TextEdit() {
+                                    NewText = "new text",
+                                    Range = new Range(new Position(1, 1), new Position(2,2))
+                                },
+                                new TextEdit() {
+                                    NewText = "new text2",
+                                    Range = new Range(new Position(3, 3), new Position(4,4))
+                                }
+                            }
+                        }
+                    }
+                }
+            };
+            var result = Fixture.SerializeObject(model);
+
+            result.Should().Be(expected);
+
+            var deresult = new Serializer(ClientVersion.Lsp3).DeserializeObject<ApplyWorkspaceEditParams>(expected);
+            deresult.Should().BeEquivalentTo(model);
+        }
+
         [Theory, JsonFixture]
         public void DocumentChangesTest(string expected)
         {

test/Lsp.Tests/Models/ApplyWorkspaceEditParamsTests_$NonStandardCharactersTest.json

@@ -0,0 +1,34 @@
+{
+    "edit": {
+        "changes": {
+            "file:///abc/123/M%C3%B6rk%C3%B6.cs": [
+                {
+                    "range": {
+                        "start": {
+                            "line": 1,
+                            "character": 1
+                        },
+                        "end": {
+                            "line": 2,
+                            "character": 2
+                        }
+                    },
+                    "newText": "new text"
+                },
+                {
+                    "range": {
+                        "start": {
+                            "line": 3,
+                            "character": 3
+                        },
+                        "end": {
+                            "line": 4,
+                            "character": 4
+                        }
+                    },
+                    "newText": "new text2"
+                }
+            ]
+        }
+    }
+}