Skip to content

Branches, Deprication #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IanDoarn opened this issue Aug 31, 2017 · 10 comments
Closed

Branches, Deprication #60

IanDoarn opened this issue Aug 31, 2017 · 10 comments

Comments

@IanDoarn
Copy link
Contributor

To everyone who has contributed.

We've been making quite a few changes recently and generally all the time now. Most of what I've been doing is fixing syntaxing to comply with PEP and in turn have been renaming quite a few things. I've noticed we've been renaming things or restructuring things.

Here's my question(s) to you all:

Who all actively use this?

We change things a lot and this main repository does not have dev branches. Also, and I'm guilty of this, renaming things breaks code. Maybe we should have a dev branch now and also implement a way of warning the user of deprecation. In an old project of mine I implemented decorators for functions that where or were being deprecated.

Just my two cents!

@OmkarPathak
Copy link
Owner

I agree that we should have a development branch.

@IanDoarn
Copy link
Contributor Author

@OmkarPathak would you be opposed to granting other people write permissions to this repo? Maybe the highest contributing people?

@OmkarPathak
Copy link
Owner

I would be happy to give write permissions. I am creating a dev branch and giving necessary permissions in sometime.

@IanDoarn
Copy link
Contributor Author

@OmkarPathak 👍 Who will you be granting to? I think @Tjstretchalot is an excellent candidate

@Tjstretchalot
Copy link
Contributor

I'm personally happy either way with committing to branches on the main repo and then pull requests into master or committing into my fork then pull requests into master. One advantage of on the main repo is we can see the live documentation without having separate links. One advantage to forks is you can rewrite history if you mess up and it won't be visible to anyone else (unless you have multiple people working on your fork of course)

@OmkarPathak
Copy link
Owner

I am giving write permissions to @Tjstretchalot as well as @IanDoarn 👍

@OmkarPathak
Copy link
Owner

I have also created a dev branch. We three will be making changes on this branch and pushing the commits to the main branch whenever we feel right and all the codes runs without any errors.

@Tjstretchalot
Copy link
Contributor

Tjstretchalot commented Aug 31, 2017

@OmkarPathak I pushed what I was about to push to my fork to dev to test. We should add a link to the documentation for the dev/ branch in the readme. This issue should help explain it: readthedocs/readthedocs.org#4

@OmkarPathak
Copy link
Owner

Just a little problem. I can't see dev branch in Readthedocs > Admin > Versions

@OmkarPathak
Copy link
Owner

Solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants