Skip to content

Allow a codeowner to approve workflow run #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saschanaz opened this issue Aug 22, 2021 · 7 comments
Closed

Allow a codeowner to approve workflow run #26

saschanaz opened this issue Aug 22, 2021 · 7 comments

Comments

@saschanaz
Copy link
Contributor

https://octokit.github.io/rest.js/v18#actions-approve-workflow-run

TypeScript-DOM-lib-generator does not allow PRs from first time contributors to run workflows and thus blocks code owner merging. Allowing codeowners to approve them would be great.

@saschanaz
Copy link
Contributor Author

Wait, this requires write permission 😬

@saschanaz
Copy link
Contributor Author

Ah, that should be okay, since it just uses GITHUB_TOKEN.

@orta
Copy link
Collaborator

orta commented Aug 23, 2021

For DT I built out a system to auto-allow it, IMO we could call this automatically if any PR is non-maintainer?

@saschanaz
Copy link
Contributor Author

saschanaz commented Aug 23, 2021

For DT I built out a system to auto-allow it, IMO we could call this automatically if any PR is non-maintainer?

In that case you can adjust the settings in Settings -> Actions rather than writing anything.

@orta
Copy link
Collaborator

orta commented Aug 24, 2021

TIL'd!

@orta
Copy link
Collaborator

orta commented Aug 24, 2021

I've changed this setting this for the DOM types repo, should be fine 👍🏻

@saschanaz
Copy link
Contributor Author

Cool, will close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants