-
Notifications
You must be signed in to change notification settings - Fork 16
Allow a codeowner to approve workflow run #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Wait, this requires write permission 😬 |
Ah, that should be okay, since it just uses GITHUB_TOKEN. |
For DT I built out a system to auto-allow it, IMO we could call this automatically if any PR is non-maintainer? |
In that case you can adjust the settings in Settings -> Actions rather than writing anything. |
TIL'd! |
I've changed this setting this for the DOM types repo, should be fine 👍🏻 |
Cool, will close this then. |
https://octokit.github.io/rest.js/v18#actions-approve-workflow-run
TypeScript-DOM-lib-generator does not allow PRs from first time contributors to run workflows and thus blocks code owner merging. Allowing codeowners to approve them would be great.
The text was updated successfully, but these errors were encountered: