Merge pull request #99 from heyman/fix-ios-cleanup

Fix issue causing WebViewExt to not be removed/cleaned up on iOS

Author: m-abs

.vscode/settings.json

@@ -57,8 +57,11 @@
     "{demo,unittest}/platforms/**/*": true
   },
   "cSpell.words": [
+    "APPICON",
+    "ASSETCATALOG",
     "Freiling",
     "HTMLX",
+    "IPHONEOS",
     "Morten",
     "NSURL",
     "Notalib",
@@ -74,6 +77,7 @@
     "armeabi",
     "bootstrapper",
     "devtool",
+    "dont",
     "downlevel",
     "endregion",
     "filepath",

demo/app/App_Resources/iOS/build.xcconfig

@@ -1,6 +1,8 @@
 // You can add custom settings here
 // for example you can uncomment the following line to force distribution code signing
-// CODE_SIGN_IDENTITY = iPhone Distribution 
+// CODE_SIGN_IDENTITY = iPhone Distribution
 // To build for device with XCode 8 you need to specify your development team. More info: https://developer.apple.com/library/prerelease/content/releasenotes/DeveloperTools/RN-Xcode/Introduction.html
 // DEVELOPMENT_TEAM = YOUR_TEAM_ID;
 ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
+VALIDATE_WORKSPACE = YES;
+IPHONEOS_DEPLOYMENT_TARGET = 9.3;

demo/app/main-page.ts

@@ -1,14 +1,5 @@
-import * as trace from "@nativescript/core/trace";
-import { Button } from "@nativescript/core/ui/button";
-import { EventData, Page } from "@nativescript/core/ui/page/page";
-import {
-    EnterFullscreenEventData,
-    isAndroid,
-    LoadEventData,
-    LoadFinishedEventData,
-    ShouldOverrideUrlLoadEventData,
-    WebViewExt,
-} from "@nota/nativescript-webview-ext";
+import { Button, EventData, Page, Trace as trace } from "@nativescript/core";
+import { EnterFullscreenEventData, LoadEventData, LoadFinishedEventData, ShouldOverrideUrlLoadEventData, WebViewExt } from "@nota/nativescript-webview-ext";
 import * as fastEqual from "fast-deep-equal";
 
 let webview: WebViewExt;
@@ -26,7 +17,7 @@ let gotMessageData: any = null;
 export function webviewLoaded(args: LoadEventData) {
     webview = args.object;
 
-    if (isAndroid) {
+    if (global.isAndroid) {
         webview.src = "http://10.0.2.2:8080";
     } else {
         webview.src = "http://localhost:8080";

demo/app/package.json

@@ -0,0 +1,11 @@
+import { NativeScriptConfig } from "@nativescript/core";
+
+export default {
+    id: "dk.nota.webviewdemo",
+    appResourcesPath: "app/App_Resources",
+    android: {
+        v8Flags: "--expose_gc",
+        markingMode: "none",
+    },
+    appPath: "app",
+} as NativeScriptConfig;