Skip to content

Commit d1efc85

Browse files
author
EC2 Default User
committed
fix: Fix issue where Processing job in Local mode would call DescribeLogStreams() against CloudWatch logs endpoint. Issue aws#2253
1 parent 42a2929 commit d1efc85

File tree

2 files changed

+29
-0
lines changed

2 files changed

+29
-0
lines changed

src/sagemaker/local/local_session.py

+15
Original file line numberDiff line numberDiff line change
@@ -546,6 +546,21 @@ def logs_for_job(self, job_name, wait=False, poll=5, log_type="All"):
546546
# on local mode.
547547
pass # pylint: disable=unnecessary-pass
548548

549+
def logs_for_processing_job(self, job_name, wait=False, poll=10):
550+
"""A no-op method meant to override the sagemaker client.
551+
552+
Args:
553+
job_name:
554+
wait: (Default value = False)
555+
poll: (Default value = 10)
556+
557+
Returns:
558+
559+
"""
560+
# override logs_for_job() as it doesn't need to perform any action
561+
# on local mode.
562+
pass # pylint: disable=unnecessary-pass
563+
549564

550565
class file_input(object):
551566
"""Amazon SageMaker channel configuration for FILE data sources, used in local mode."""

tests/unit/test_local_session.py

+14
Original file line numberDiff line numberDiff line change
@@ -551,6 +551,20 @@ def test_describe_transform_job_does_not_exist(LocalSession, _LocalTransformJob)
551551
local_sagemaker_client.describe_transform_job("transform-job-does-not-exist")
552552

553553

554+
@patch("sagemaker.local.image._SageMakerContainer.process")
555+
@patch("sagemaker.local.local_session.LocalSession")
556+
def test_logs_for_job(process, LocalSession):
557+
local_job_logs = LocalSession.logs_for_job("my-processing-job")
558+
assert local_job_logs is not None
559+
560+
561+
@patch("sagemaker.local.image._SageMakerContainer.process")
562+
@patch("sagemaker.local.local_session.LocalSession")
563+
def test_logs_for_processing_job(process, LocalSession):
564+
local_processing_job_logs = LocalSession.logs_for_processing_job("my-processing-job")
565+
assert local_processing_job_logs is not None
566+
567+
554568
@patch("sagemaker.local.local_session.LocalSession")
555569
def test_describe_endpoint_config(LocalSession):
556570
local_sagemaker_client = sagemaker.local.local_session.LocalSagemakerClient()

0 commit comments

Comments
 (0)